Skip to content

[Issue] Speedup static content deploy for specific theme #30184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
m2-assistant bot opened this issue Sep 24, 2020 · 2 comments · Fixed by #30090
Closed

[Issue] Speedup static content deploy for specific theme #30184

m2-assistant bot opened this issue Sep 24, 2020 · 2 comments · Fixed by #30090
Labels
Component: Deploy Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Sep 24, 2020 •
edited by engcom-Bravo
Loading

This issue is automatically created based on existing pull request: #30090: Speedup static content deploy for specific theme

Preconditions (*)

2.4-develop

Description (*)

This PR adds improvement for ability to deploy the only specific theme(s) for multiple locales, so it should improve build phase of deployment for the those who use single theme with different locales.

Basically what I did - i just removed packages from all themes from which inherited requested theme, so in case of Luma - we have only 1 parent theme, but for people who has bigger inheritance - different will be bigger.

How I tested:

php bin/magento setup:upgrade
php bin/magento setup:static-content:deploy -f -t Magento/luma -- en_AU en_CA en_IE en_NZ en_GB en_US

Before:
~130 seconds ❌
image

After:
~65 seconds ✔
image

Steps to reproduce (*)

php bin/magento setup:upgrade
php bin/magento setup:static-content:deploy -f -t Magento/luma --no-parent -- en_AU en_CA en_IE en_NZ en_GB en_US

Actual result (*)

Content deploy with --no-parent parameter was not available
noparrent
Performing php bin/magento setup:static-content:deploy -f -t Magento/luma -- en_AU en_CA en_IE en_NZ en_GB en_US finished in 269 seconds
Before

Expected result (*)

php bin/magento setup:static-content:deploy -f -t Magento/luma --no-parent -- en_AU en_CA en_IE en_NZ en_GB en_US became available and finished faster
After
@m2-assistant m2-assistant bot added Component: Deploy Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 24, 2020
@m2-assistant m2-assistant bot mentioned this issue Sep 24, 2020
Merged
5 tasks
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Sep 24, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Sep 24, 2020
@ghost ghost unassigned ihor-sviziev Oct 19, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Oct 19, 2020
@engcom-Bravo engcom-Bravo added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Nov 3, 2020
@ghost ghost added Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Nov 3, 2020
@engcom-Bravo engcom-Bravo added Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch and removed Progress: PR in progress labels Nov 3, 2020
@ghost ghost added Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Nov 3, 2020
@engcom-Bravo engcom-Bravo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Nov 3, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-38852 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@ghost ghost unassigned ihor-sviziev Nov 13, 2020
@magento-engcom-team magento-engcom-team added Reported on 2.4.0 Indicates original Magento version for the Issue report. Fixed in 2.4.x The issue has been fixed in 2.4-develop branch labels Nov 13, 2020
@magento-engcom-team
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #30090 by @ihor-sviziev in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@engcom-Hotel engcom-Hotel moved this to Pull Request In Progress in Low Priority Backlog Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Deploy Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Speedup static content deploy for specific theme ihor-sviziev/magento2
3 participants
@ihor-sviziev @magento-engcom-team @engcom-Bravo