Skip to content

[Issue] Check if copy method is copy before sending comment email #29915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 4 tasks
m2-assistant bot opened this issue Sep 4, 2020 · 2 comments · Fixed by #29911
Closed
2 of 4 tasks

[Issue] Check if copy method is copy before sending comment email #29915

m2-assistant bot opened this issue Sep 4, 2020 · 2 comments · Fixed by #29911
Assignees
@JeroenVanLeusden
Labels
Component: Sales Event: MageCONF CD 2020 Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Sep 4, 2020 •
edited by engcom-Alfa
Loading

This issue is automatically created based on existing pull request: #29911: Check if copy method is copy before sending comment email

Preconditions (*)

Magento 2.4-develop

As seen in the comments email copies should only be sent as separated emails if their copy method is copy.

Screenshot from 2020-10-19 10-28-34

Steps to reproduce: (*)

  1. Go to Admin -> Stores -> Configuration -> Sales -> Sales Email -> Order Comments and set Enabled to Yes
  2. Add email address to Send Order Comment Email Copy To
  3. Set Send Order Comments Email Copy Method to Bcc
  4. Place order.
  5. Add order comment in order overview (adminhtml area) and uncheck notify customer.

Actual Result: ✖️ a copy of the email was sent

Screenshot from 2020-10-16 15-07-38

Expected Result: ✔️ Email copy should not be send because notify customer is disabled and copy set to bcc.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Sales Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 4, 2020
@JeroenVanLeusden JeroenVanLeusden mentioned this issue Sep 4, 2020
Merged
5 tasks
@ghost ghost assigned JeroenVanLeusden Sep 4, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Sep 4, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR in progress labels Sep 24, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Sep 24, 2020
@engcom-Alfa engcom-Alfa added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Oct 19, 2020
@m2-community-project m2-community-project bot added Progress: ready for dev and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Oct 19, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 19, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-38519 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #29911 by @JeroenVanLeusden in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Oct 24, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.4.0 Indicates original Magento version for the Issue report. label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeroenVanLeusden JeroenVanLeusden

Labels
Component: Sales Event: MageCONF CD 2020 Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
High Priority Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check if copy method is copy before sending comment email JeroenVanLeusden/magento2
4 participants
@sdzhepa @JeroenVanLeusden @magento-engcom-team @engcom-Alfa