Skip to content

[Issue] Checkout / Sales Rules / Get rid of redundant DB query #29453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks
m2-assistant bot opened this issue Aug 10, 2020 · 3 comments · Fixed by #29376
Closed
4 tasks

[Issue] Checkout / Sales Rules / Get rid of redundant DB query #29453

m2-assistant bot opened this issue Aug 10, 2020 · 3 comments · Fixed by #29376
Assignees
@lbajsarowicz
Labels
Component: Rule Component: SalesRule Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 10, 2020 •
edited by engcom-Alfa
Loading

This issue is automatically created based on existing pull request: #29376: Checkout / Sales Rules / Get rid of redundant DB query

Preconditions:

  • Loading data in the loop?
  • No, thank you!

By replacing direct SQL query with Data Provider that was already used in this Validator class allowed me to drastically reduce the cost of checkout placing process.

Local environment

20 products in cart

image

Custom project

22 products in cart

image

Related Pull Requests

Fixed Issues (if relevant)

Performance of Checkout

Steps to reproduce:

  1. Install sample data
  2. Create Catalog rule based on category
  3. Add plenty of products (15 - inf.)
  4. Place an order.

Actual Result:
2020-08-07_14-13

Expected Result:

Checkout should work faster by 20 - 30%

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Rule Component: SalesRule Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Aug 10, 2020
@lbajsarowicz lbajsarowicz mentioned this issue Aug 10, 2020
Merged
5 tasks
@ghost ghost assigned lbajsarowicz Aug 10, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Aug 10, 2020
@engcom-Alfa engcom-Alfa added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Aug 11, 2020
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Aug 11, 2020
@engcom-Alfa engcom-Alfa added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Aug 11, 2020
@ghost ghost removed the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Aug 11, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Aug 11, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-36620 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@sdzhepa sdzhepa added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Aug 12, 2020
@sidolov sidolov added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Aug 13, 2020
@magento-engcom-team magento-engcom-team added Progress: ready for dev Fixed in 2.4.x The issue has been fixed in 2.4-develop branch and removed Progress: PR in progress labels Aug 14, 2020
@magento-engcom-team
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #29376 by @lbajsarowicz in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

@JosephLeedy
Copy link

JosephLeedy commented Oct 9, 2020 •
edited
Loading

@magento-engcom-team I don't see this fix in Magento Commerce 2.4.1. Am I missing something?

@sdzhepa sdzhepa mentioned this issue May 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbajsarowicz lbajsarowicz

Labels
Component: Rule Component: SalesRule Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Checkout / Sales Rules / Get rid of redundant DB query lbajsarowicz/magento2-contributions
6 participants
@lbajsarowicz @JosephLeedy @sdzhepa @sidolov @magento-engcom-team @engcom-Alfa