#5023 - It is not possible to add MS tile image meta via default_head_blocks.xml

Author: Vasilii

lib/internal/Magento/Framework/View/Page/Config.php

@@ -130,6 +130,11 @@ class Config
         'title' => null,
     ];
 
+    /**
+     * @var array
+     */
+    protected $additionalMetaAssets = ['msapplication-TileImage'];
+
     /**
      * @var \Magento\Framework\App\State
      */
@@ -539,6 +544,30 @@ public function addBodyClass($className)
         return $this;
     }
 
+    /**
+     * Retrieve the additional meta assets
+     *
+     * @return array
+     */
+    public function getAdditionalMetaAssets()
+    {
+        return $this->additionalMetaAssets;
+    }
+    /**
+     * Adjust metadata content url
+     *
+     * @param string $content
+     * @return string $content
+     */
+    public function getMetaAssetUrl($content)
+    {
+        $parsed = parse_url($content);
+        if (empty($parsed['scheme'])) {
+            return $this->assetRepo->getUrl($content);
+        }
+        return $content;
+    }
+
     /**
      * Set additional element attribute
      *

lib/internal/Magento/Framework/View/Page/Config/Renderer.php

@@ -157,6 +157,10 @@ protected function processMetadataContent($name, $content)
         if (method_exists($this->pageConfig, $method)) {
             $content = $this->pageConfig->$method();
         }
+        if ($content && in_array($name, $this->pageConfig->getAdditionalMetaAssets())) {
+            $content = $this->pageConfig->getMetaAssetUrl($content);
+        }
+
         return $content;
     }
 

lib/internal/Magento/Framework/View/Test/Unit/Page/Config/RendererTest.php

@@ -171,6 +171,11 @@ public function testRenderMetadata()
             ->method('getMetadata')
             ->will($this->returnValue($metadata));
 
+        $this->pageConfigMock
+            ->expects($this->any())
+            ->method('getAdditionalMetaAssets')
+            ->will($this->returnValue(['msapplication-TileImage']));
+
         $this->assertEquals($expected, $this->renderer->renderMetadata());
     }
 

lib/internal/Magento/Framework/View/Test/Unit/Page/ConfigTest.php

@@ -369,6 +369,20 @@ public function testAddRss()
         $this->assertInstanceOf(\Magento\Framework\View\Page\Config::class, $this->model->addRss($title, $href));
     }
 
+    public function testGetMetaAssetUrlWithUrlInContent()
+    {
+        $this->assetRepo->expects($this->never())->method('getUrl');
+        $this->assertEquals('http://test.com/image.png', $this->model->getMetaAssetUrl('http://test.com/image.png'));
+    }
+
+    public function testGetMetaAssetUrlWithoutUrlInContent()
+    {
+        $this->assetRepo->expects($this->once())->method('getUrl')->with('image.png')->will(
+            $this->returnValue('http://test.com/image.png')
+        );
+        $this->assertEquals('http://test.com/image.png', $this->model->getMetaAssetUrl('image.png'));
+    }
+
     public function testAddBodyClass()
     {
         $className = 'test class';