Merge pull request #3145 from magento-thunder/MAGETWO-94369

[thunder] MAGETWO-94369: [Forwardport] Move cron improvements from 2.2 to 2.3

Author: Stanislav Idolov

app/code/Magento/Cron/Model/Schedule.php

@@ -71,14 +71,16 @@ public function __construct(
     }
 
     /**
-     * @return void
+     * @inheritdoc
      */
     public function _construct()
     {
         $this->_init(\Magento\Cron\Model\ResourceModel\Schedule::class);
     }
 
     /**
+     * Set cron expression.
+     *
      * @param string $expr
      * @return $this
      * @throws \Magento\Framework\Exception\CronException
@@ -87,15 +89,15 @@ public function setCronExpr($expr)
     {
         $e = preg_split('#\s+#', $expr, null, PREG_SPLIT_NO_EMPTY);
         if (sizeof($e) < 5 || sizeof($e) > 6) {
-            throw new CronException(__('The "%1" cron expression is invalid. Verify and try again.', $expr));
+            throw new CronException(__('Invalid cron expression: %1', $expr));
         }
 
         $this->setCronExprArr($e);
         return $this;
     }
 
     /**
-     * Checks the observer's cron expression against time
+     * Checks the observer's cron expression against time.
      *
      * Supports $this->setCronExpr('* 0-5,10-59/5 2-10,15-25 january-june/2 mon-fri')
      *
@@ -125,6 +127,8 @@ public function trySchedule()
     }
 
     /**
+     * Match cron expression.
+     *
      * @param string $expr
      * @param int $num
      * @return bool
@@ -184,13 +188,15 @@ public function matchCronExpression($expr, $num)
         }
 
         if ($from === false || $to === false) {
-            throw new CronException(__('The "%1" cron expression is invalid. Verify and try again.', $expr));
+            throw new CronException(__('Invalid cron expression: %1', $expr));
         }
 
         return $num >= $from && $num <= $to && $num % $mod === 0;
     }
 
     /**
+     * Get number of a month.
+     *
      * @param int|string $value
      * @return bool|int|string
      */