🔃 [EngCom] Public Pull Requests - 2.3-develop Minor Fixes

Accepted Public Pull Requests:
 - #20612: minicart-three-digit-quantity-cutoff (by @parag2jcommerce)
 - #20196: Confirmation-pop-up-at-mobile-view-not-proper (by @priti2jcommerce)
 - #20582: correct spelling (by @ravi-chandra3197)
 - #20531: [TASK] Removed typo in di.xml of GroupedImportExport (by @lewisvoncken)
 - #20564: issue fixed #20563 Go to shipping information, Update qty & Addresses� (by @cedarvinda)
 - #20561: Update popup_content.phtml (by @magicsunday)
 - #19826: Missing PHPDoc comment for method (by @lfluvisotto)
 - #20501: recent-order-product-title-misaligned (by @parag2jcommerce)
 - #20519: bundle-product-radio-button-misalign (by @parag2jcommerce)
 - #20498: Fixing the styling issue on customizable options (by @eduard13)
 - #20344: Fixed #20282 Module Catalog Url Rewrite: Permanent Redirect for old URL is missed when product was imported (by @ankur-cedcoss)
 - #20421: Fixes incorrect where condition when deleting swatch option, it delet… (by @hostep)
 - #20410: #20409 Fixed Unnecessary slash in namespace (by @milindsingh)
 - #20341: PHPDocs fixes [Sales module] (by @SikailoISM)
 - #20281: Apply-discount-code-placeholder-get-cut ::Apply discount code placeho� (by @ajay2jcommerce)
 - #20368: issue fixed #20367 In Compare Products page showing horizontal scroll� (by @cedarvinda)
 - #20354: Issue#20277 fixed for 2.3.x (by @maheshWebkul721)
 - #20262: My-Accounttele-phone-field-require-no-validation-appear (by @dipti2jcommerce)
 - #20114: Fixed issue #20113  Widget option labels are misalinged (by @GovindaSharma)
 - #20146: Fixed error while adding new review from admin panel (by @suneet64)
 - #20142: Fixed issue #19942 Success message is not showing when creating invoice & shipment simultaniously  (by @Surabhi-Cedcoss)
 - #19502: Fix issue 19501 - Sales order Bundle product item alignment issue (by @abrarpathan19)


Fixed GitHub Issues:
 - #20611: Minicart qty input box get distorted with 3-digit (reported by @parag2jcommerce) has been fixed in #20612 by @parag2jcommerce in 2.3-develop branch
   Related commits:
     1. 3e9d892

 - #20176: Confirmation pop-up at mobile view not proper (reported by @priti2jcommerce) has been fixed in #20196 by @priti2jcommerce in 2.3-develop branch
   Related commits:
     1. 66b47ea

 - #20563: Go to shipping information, Update qty & Addresses and Enter a new address button Not aligned from left and right in 767px screen size (reported by @swetacedcoss) has been fixed in #20564 by @cedarvinda in 2.3-develop branch
   Related commits:
     1. 93b8077

 - #20500: Recent Order Product Title Misaligned in Sidebar (reported by @parag2jcommerce) has been fixed in #20501 by @parag2jcommerce in 2.3-develop branch
   Related commits:
     1. 34e5c6d
     2. f0cb896
     3. 62bfb5c

 - #20518: On Bundle product radio button misalign (reported by @parag2jcommerce) has been fixed in #20519 by @parag2jcommerce in 2.3-develop branch
   Related commits:
     1. 99f7f4a

 - #20497: Product customizable options issue (reported by @eduard13) has been fixed in #20498 by @eduard13 in 2.3-develop branch
   Related commits:
     1. 6f10b64

 - #20282: Module Catalog Url Rewrite: Permanent Redirect for old URL is missed when product was imported (reported by @olegAleksin) has been fixed in #20344 by @ankur-cedcoss in 2.3-develop branch
   Related commits:
     1. e331b3f
     2. 8668528

 - #20396: Changing attribute from swatch to dropdown deletes swatch options for all attributes (reported by @maderlock) has been fixed in #20421 by @hostep in 2.3-develop branch
   Related commits:
     1. b5efb5c
     2. 6829ce8

 - #20409: Magento\Catalog\Api\ProductRenderListInterface returns products regardless of visibility (reported by @Floddy) has been fixed in #20410 by @milindsingh in 2.3-develop branch
   Related commits:
     1. f199b7d

 - #20278: Apply discount code placeholder gets cut in Tab portriat view on cart page (reported by @yashwant2jcommerce) has been fixed in #20281 by @ajay2jcommerce in 2.3-develop branch
   Related commits:
     1. 5c4d71b
     2. 07ad944

 - #20367: In Compare Products page showing horizontal scrollbar In body But It should appear in **table-wrapper comparison** div For mobile device (reported by @swetacedcoss) has been fixed in #20368 by @cedarvinda in 2.3-develop branch
   Related commits:
     1. 3b97fd5
     2. c310cd7

 - #20277: Uploaded file for custom option can't be downloaded again (reported by @dverkade) has been fixed in #20354 by @maheshWebkul721 in 2.3-develop branch
   Related commits:
     1. 0759026
     2. 9c6af93
     3. bf246da
     4. 45c6fc7
     5. 3a01bc0
     6. 18ae227

 - #20261: In My Account dashboard page when we create new address from address book telephone field is require,but no validation appear while submission  (reported by @dipti2jcommerce) has been fixed in #20262 by @dipti2jcommerce in 2.3-develop branch
   Related commits:
     1. 80d87ec
     2. 6ebbe3d
     3. 3bd68e5

 - #20113: Widget option labels are misalinged (reported by @yashwant2jcommerce) has been fixed in #20114 by @GovindaSharma in 2.3-develop branch
   Related commits:
     1. d621498
     2. 95defcc

 - #20122: Getting error on adding new review from admin panel (reported by @mohammadzakir) has been fixed in #20146 by @suneet64 in 2.3-develop branch
   Related commits:
     1. da809e3
     2. 130f1ae
     3. eed3bc3

 - #19942: Success message is not showing when creating invoice & shipment simultaniously  (reported by @Surabhi-Cedcoss) has been fixed in #20142 by @Surabhi-Cedcoss in 2.3-develop branch
   Related commits:
     1. e6c41ba
     2. 0689a17

 - #19501: Sales order Bundle product item alignment issue (reported by @abrarpathan19) has been fixed in #19502 by @abrarpathan19 in 2.3-develop branch
   Related commits:
     1. 5d7cd50
     2. fbf5ebb
     3. 9c04589
     4. 2479f44

Author: magento-engcom-team

app/code/Magento/Catalog/Api/Data/ProductRender/ImageInterface.php

@@ -92,6 +92,7 @@ public function setWidth($width);
 
     /**
      * Retrieve image label
+     *
      * Image label is short description of this image
      *
      * @return string
@@ -111,7 +112,7 @@ public function setLabel($label);
     /**
      * Retrieve resize width
      *
-     * This width is image dimension, which represents the width, that can be used for perfomance improvements
+     * This width is image dimension, which represents the width, that can be used for performance improvements
      *
      * @return float
      * @since 101.1.0
@@ -128,6 +129,8 @@ public function getResizedWidth();
     public function setResizedWidth($width);
 
     /**
+     * Set resized height
+     *
      * @param string $height
      * @return void
      * @since 101.1.0

app/code/Magento/CatalogInventory/Model/ResourceModel/Stock/Item.php

@@ -263,6 +263,12 @@ public function updateLowStockDate(int $websiteId)
         $connection->update($this->getMainTable(), $value, $where);
     }
 
+    /**
+     * Get Manage Stock Expression
+     *
+     * @param string $tableAlias
+     * @return \Zend_Db_Expr
+     */
     public function getManageStockExpr(string $tableAlias = ''): \Zend_Db_Expr
     {
         if ($tableAlias) {
@@ -277,6 +283,12 @@ public function getManageStockExpr(string $tableAlias = ''): \Zend_Db_Expr
         return $manageStock;
     }
 
+    /**
+     * Get Backorders Expression
+     *
+     * @param string $tableAlias
+     * @return \Zend_Db_Expr
+     */
     public function getBackordersExpr(string $tableAlias = ''): \Zend_Db_Expr
     {
         if ($tableAlias) {
@@ -291,6 +303,12 @@ public function getBackordersExpr(string $tableAlias = ''): \Zend_Db_Expr
         return $itemBackorders;
     }
 
+    /**
+     * Get Minimum Sale Quantity Expression
+     *
+     * @param string $tableAlias
+     * @return \Zend_Db_Expr
+     */
     public function getMinSaleQtyExpr(string $tableAlias = ''): \Zend_Db_Expr
     {
         if ($tableAlias) {

app/code/Magento/CatalogInventory/etc/di.xml

@@ -111,7 +111,7 @@
             <argument name="batchSizeManagement" xsi:type="object">Magento\CatalogInventory\Model\Indexer\Stock\BatchSizeManagement</argument>
         </arguments>
     </type>
-    <type name="\Magento\Framework\Data\CollectionModifier">
+    <type name="Magento\Framework\Data\CollectionModifier">
         <arguments>
             <argument name="conditions" xsi:type="array">
                 <item name="stockStatusCondition" xsi:type="object">Magento\CatalogInventory\Model\ProductCollectionStockCondition</item>

app/code/Magento/CatalogSearch/Setup/Patch/Data/MySQLSearchDeprecationNotification.php

@@ -25,6 +25,10 @@ class MySQLSearchDeprecationNotification implements \Magento\Framework\Setup\Pat
      */
     private $notifier;
 
+    /**
+     * @param \Magento\Framework\Search\EngineResolverInterface $searchEngineResolver
+     * @param \Magento\Framework\Notification\NotifierInterface $notifier
+     */
     public function __construct(
         \Magento\Framework\Search\EngineResolverInterface $searchEngineResolver,
         \Magento\Framework\Notification\NotifierInterface $notifier

app/code/Magento/CatalogUrlRewrite/Observer/AfterImportDataObserver.php

@@ -135,6 +135,7 @@ class AfterImportDataObserver implements ObserverInterface
         'url_path',
         'name',
         'visibility',
+        'save_rewrites_history'
     ];
 
     /**
@@ -199,6 +200,7 @@ public function __construct(
 
     /**
      * Action after data import.
+     *
      * Save new url rewrites and remove old if exist.
      *
      * @param Observer $observer
@@ -267,6 +269,8 @@ protected function _populateForUrlGeneration($rowData)
     }
 
     /**
+     * Add store id to product data.
+     *
      * @param \Magento\Catalog\Model\Product $product
      * @param array $rowData
      * @return void
@@ -436,6 +440,8 @@ protected function currentUrlRewritesRegenerate()
     }
 
     /**
+     * Generate url-rewrite for outogenerated url-rewirte.
+     *
      * @param UrlRewrite $url
      * @param Category $category
      * @return array
@@ -470,6 +476,8 @@ protected function generateForAutogenerated($url, $category)
     }
 
     /**
+     * Generate url-rewrite for custom url-rewirte.
+     *
      * @param UrlRewrite $url
      * @param Category $category
      * @return array
@@ -503,6 +511,8 @@ protected function generateForCustom($url, $category)
     }
 
     /**
+     * Retrieve category from url metadata.
+     *
      * @param UrlRewrite $url
      * @return Category|null|bool
      */
@@ -517,6 +527,8 @@ protected function retrieveCategoryFromMetadata($url)
     }
 
     /**
+     * Check, category suited for url-rewrite generation.
+     *
      * @param \Magento\Catalog\Model\Category $category
      * @param int $storeId
      * @return bool

app/code/Magento/Customer/Model/Indexer/CustomerGroupDimensionProvider.php

@@ -11,6 +11,9 @@
 use Magento\Framework\Indexer\DimensionFactory;
 use Magento\Framework\Indexer\DimensionProviderInterface;
 
+/**
+ * Class CustomerGroupDimensionProvider
+ */
 class CustomerGroupDimensionProvider implements DimensionProviderInterface
 {
     /**
@@ -34,12 +37,19 @@ class CustomerGroupDimensionProvider implements DimensionProviderInterface
      */
     private $dimensionFactory;
 
+    /**
+     * @param CustomerGroupCollectionFactory $collectionFactory
+     * @param DimensionFactory $dimensionFactory
+     */
     public function __construct(CustomerGroupCollectionFactory $collectionFactory, DimensionFactory $dimensionFactory)
     {
         $this->dimensionFactory = $dimensionFactory;
         $this->collectionFactory = $collectionFactory;
     }
 
+    /**
+     * @inheritdoc
+     */
     public function getIterator(): \Traversable
     {
         foreach ($this->getCustomerGroups() as $customerGroup) {
@@ -48,6 +58,8 @@ public function getIterator(): \Traversable
     }
 
     /**
+     * Get Customer Groups
+     *
      * @return array
      */
     private function getCustomerGroups(): array

app/code/Magento/Customer/view/frontend/templates/widget/telephone.phtml

@@ -19,7 +19,7 @@
         <?php
             $_validationClass = $block->escapeHtmlAttr(
                 $this->helper('Magento\Customer\Helper\Address')
-                     ->getAttributeValidationClass('fax')
+                     ->getAttributeValidationClass('telephone')
             );
         ?>
         <input type="text"

app/code/Magento/GroupedImportExport/etc/di.xml

@@ -9,7 +9,7 @@
     <type name="Magento\CatalogImportExport\Model\Export\RowCustomizer\Composite">
         <arguments>
             <argument name="customizers" xsi:type="array">
-                <item name="gropedProduct" xsi:type="string">Magento\GroupedImportExport\Model\Export\RowCustomizer</item>
+                <item name="groupedProduct" xsi:type="string">Magento\GroupedImportExport\Model\Export\RowCustomizer</item>
             </argument>
         </arguments>
     </type>

app/code/Magento/Review/Block/Adminhtml/Add.php

@@ -56,7 +56,7 @@ protected function _construct()
                     },
                     loadProductData : function() {
                         jQuery.ajax({
-                            type: "POST",
+                            type: "GET",
                             url: review.productInfoUrl,
                             data: {
                                 form_key: FORM_KEY

app/code/Magento/Sales/Block/Adminhtml/Order/Create/Load.php

@@ -29,7 +29,7 @@ class Load extends \Magento\Framework\View\Element\Template
     /**
      * @param \Magento\Framework\View\Element\Template\Context $context
      * @param \Magento\Framework\Json\EncoderInterface $jsonEncoder
-     * @param \Magento\Framework\View\Helper\Js $adminhtmlJs
+     * @param \Magento\Framework\View\Helper\Js $jsHelper
      * @param array $data
      */
     public function __construct(