Skip to content

Commit 0ff166f

Browse files
ENGCOM-9373: Replace repetitive actions with Action Groups in AdminCreateCategoryWithFiveNestingTest #34610
- Merge Pull Request #34610 from kate-kyzyma/magento2:Refactoring-AdminCreateCategoryWithFiveNestingTest - Merged commits: 1. a9ed32e
2 parents 7900123 + a9ed32e commit 0ff166f

File tree

2 files changed

+34
-10
lines changed

2 files changed

+34
-10
lines changed
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
11+
<actionGroup name="AdminClickAddSubcategoryButtonActionGroup">
12+
<click selector="{{AdminCategorySidebarActionSection.AddSubcategoryButton}}" stepKey="clickOnAddSubCategoryButton"/>
13+
</actionGroup>
14+
</actionGroups>

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateCategoryWithFiveNestingTest.xml

Lines changed: 20 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -37,33 +37,43 @@
3737
<!--Create Category with Five Nesting -->
3838
<actionGroup ref="AdminOpenCategoryPageActionGroup" stepKey="openAdminCategoryIndexPage"/>
3939
<!--Create Nested First Category-->
40-
<click selector="{{AdminCategorySidebarActionSection.AddSubcategoryButton}}" stepKey="clickOnAddSubCategoryButton"/>
40+
<actionGroup ref="AdminClickAddSubcategoryButtonActionGroup" stepKey="clickOnAddSubCategoryButton"/>
4141
<checkOption selector="{{AdminCategoryBasicFieldSection.EnableCategory}}" stepKey="enableCategory"/>
42-
<fillField selector="{{AdminCategoryBasicFieldSection.CategoryNameInput}}" userInput="{{FirstLevelSubCat.name}}" stepKey="fillFirstSubCategoryName"/>
42+
<actionGroup ref="AdminChangeCategoryNameActionGroup" stepKey="fillFirstSubCategoryName">
43+
<argument name="categoryName" value="{{FirstLevelSubCat.name}}"/>
44+
</actionGroup>
4345
<actionGroup ref="AdminSaveCategoryActionGroup" stepKey="saveFirstSubCategory"/>
4446
<!-- Verify success message -->
4547
<actionGroup ref="AssertAdminCategorySaveSuccessMessageActionGroup" stepKey="assertSuccessMessage"/>
4648
<!--Create Nested Second Sub Category-->
47-
<click selector="{{AdminCategorySidebarActionSection.AddSubcategoryButton}}" stepKey="clickOnAddSubCategoryButton1"/>
48-
<fillField selector="{{AdminCategoryBasicFieldSection.CategoryNameInput}}" userInput="{{SecondLevelSubCat.name}}" stepKey="fillSecondSubCategoryName"/>
49+
<actionGroup ref="AdminClickAddSubcategoryButtonActionGroup" stepKey="clickOnAddSubCategoryButton1"/>
50+
<actionGroup ref="AdminChangeCategoryNameActionGroup" stepKey="fillSecondSubCategoryName">
51+
<argument name="categoryName" value="{{SecondLevelSubCat.name}}"/>
52+
</actionGroup>
4953
<actionGroup ref="AdminSaveCategoryActionGroup" stepKey="saveSecondSubCategory"/>
5054
<!-- Verify success message -->
5155
<actionGroup ref="AssertAdminCategorySaveSuccessMessageActionGroup" stepKey="assertSuccessMessage1"/>
5256
<!--Create Nested Third Sub Category/>-->
53-
<click selector="{{AdminCategorySidebarActionSection.AddSubcategoryButton}}" stepKey="clickOnAddSubCategoryButton2"/>
54-
<fillField selector="{{AdminCategoryBasicFieldSection.CategoryNameInput}}" userInput="{{ThirdLevelSubCat.name}}" stepKey="fillThirdSubCategoryName"/>
57+
<actionGroup ref="AdminClickAddSubcategoryButtonActionGroup" stepKey="clickOnAddSubCategoryButton2"/>
58+
<actionGroup ref="AdminChangeCategoryNameActionGroup" stepKey="fillThirdSubCategoryName">
59+
<argument name="categoryName" value="{{ThirdLevelSubCat.name}}"/>
60+
</actionGroup>
5561
<actionGroup ref="AdminSaveCategoryActionGroup" stepKey="saveThirdSubCategory"/>
5662
<!-- Verify success message -->
5763
<actionGroup ref="AssertAdminCategorySaveSuccessMessageActionGroup" stepKey="assertSuccessMessage2"/>
5864
<!--Create Nested fourth Sub Category />-->
59-
<click selector="{{AdminCategorySidebarActionSection.AddSubcategoryButton}}" stepKey="clickOnAddSubCategoryButton3"/>
60-
<fillField selector="{{AdminCategoryBasicFieldSection.CategoryNameInput}}" userInput="{{FourthLevelSubCat.name}}" stepKey="fillFourthSubCategoryName"/>
65+
<actionGroup ref="AdminClickAddSubcategoryButtonActionGroup" stepKey="clickOnAddSubCategoryButton3"/>
66+
<actionGroup ref="AdminChangeCategoryNameActionGroup" stepKey="fillFourthSubCategoryName">
67+
<argument name="categoryName" value="{{FourthLevelSubCat.name}}"/>
68+
</actionGroup>
6169
<actionGroup ref="AdminSaveCategoryActionGroup" stepKey="saveFourthSubCategory"/>
6270
<!-- Verify success message -->
6371
<actionGroup ref="AssertAdminCategorySaveSuccessMessageActionGroup" stepKey="assertSuccessMessage3"/>
6472
<!--Create Nested fifth Sub Category />-->
65-
<click selector="{{AdminCategorySidebarActionSection.AddSubcategoryButton}}" stepKey="clickOnAddSubCategoryButton4"/>
66-
<fillField selector="{{AdminCategoryBasicFieldSection.CategoryNameInput}}" userInput="{{FifthLevelCat.name}}" stepKey="fillFifthSubCategoryName"/>
73+
<actionGroup ref="AdminClickAddSubcategoryButtonActionGroup" stepKey="clickOnAddSubCategoryButton4"/>
74+
<actionGroup ref="AdminChangeCategoryNameActionGroup" stepKey="fillFifthSubCategoryName">
75+
<argument name="categoryName" value="{{FifthLevelCat.name}}"/>
76+
</actionGroup>
6777
<actionGroup ref="AdminSaveCategoryActionGroup" stepKey="saveFifthLevelCategory"/>
6878
<!-- Verify success message -->
6979
<actionGroup ref="AssertAdminCategorySaveSuccessMessageActionGroup" stepKey="assertSuccessMessage4"/>

0 commit comments

Comments
 (0)