ENGCOM-2327: Avoid undefined index warning when using uppercase reserved word #16785

Stanislav Idolov · web-flow · commit 01aa067e5ef6 · 2018-07-23T08:49:34.000+03:00
diff --git a/dev/tests/static/framework/Magento/Sniffs/NamingConventions/ReservedWordsSniff.php b/dev/tests/static/framework/Magento/Sniffs/NamingConventions/ReservedWordsSniff.php
@@ -64,7 +64,7 @@ protected function validateNamespace(File $sourceFile, $stackPtr)
                     'Cannot use "%s" in namespace as it is reserved since PHP %s',
                     $stackPtr,
                     'Namespace',
-                    [$namespacePart, $this->reservedWords[$namespacePart]]
+                    [$namespacePart, $this->reservedWords[strtolower($namespacePart)]]
                 );
             }
             $stackPtr++;

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ protected function validateNamespace(File $sourceFile, $stackPtr)`
`64`	`64`	`'Cannot use "%s" in namespace as it is reserved since PHP %s',`
`65`	`65`	`$stackPtr,`
`66`	`66`	`'Namespace',`
`67`		`- [$namespacePart, $this->reservedWords[$namespacePart]]`
	`67`	`+ [$namespacePart, $this->reservedWords[strtolower($namespacePart)]]`
`68`	`68`	`);`
`69`	`69`	`}`
`70`	`70`	`$stackPtr++;`