diff --git a/docs/mftf-tests.md b/docs/mftf-tests.md deleted file mode 100644 index 718806aa5..000000000 --- a/docs/mftf-tests.md +++ /dev/null @@ -1,34 +0,0 @@ ---- -layout: full-width -title: MFTF Tests ---- - -The Magento Functional Testing Framework runs tests on every Module within Magento. These files are stored within each Module folder in the Magento repo. -This page lists all those tests so that developers can have a good sense of what is covered. - -{% assign mftf = site.data.mftf | group_by: "module" | sort: "name" %} - -{% for item in mftf %} - -### {{ item.name }} -{% for file in item.items %} -#### [{{ file.filename }}]({{file.repo}}) -{: .mftf-test-link} - -{% for test in file.tests %} -{{test.testname}} - : {{test.description}} -{: .mftf-dl} -{% endfor %} -{% endfor %} -{% endfor %} diff --git a/docs/selectors.md b/docs/selectors.md deleted file mode 100644 index 870072e15..000000000 --- a/docs/selectors.md +++ /dev/null @@ -1,35 +0,0 @@ -## Selectors - -These guidelines should help you to write high quality selectors. - -### Selectors SHOULD be written in CSS instead of XPath whenever possible - -CSS is generally easier to read than XPath. For example, `//*[@id="foo"]` in XPath can be expressed as simply as `#foo` in CSS. -See this [XPath Cheatsheet](https://devhints.io/xpath) for more examples. - -### XPath selectors SHOULD NOT use `@attribute="foo"`. - -This would fail if the attribute was `attribute="foo bar"`. -Instead you SHOULD use `contains(@attribute, "foo")` where `@attribute` is any valid attribute such as `@text` or `@class`. - -### CSS and XPath selectors SHOULD be implemented in their most simple form - -* GOOD: `#foo` -* BAD: `button[contains(@id, "foo")]` - -### CSS and XPath selectors SHOULD avoid making use of hardcoded indices - -Instead you SHOULD parameterize the selector. - -* GOOD: `.foo:nth-of-type({{index}})` -* BAD: `.foo:nth-of-type(1)` - -* GOOD: `button[contains(@id, "foo")][{{index}}]` -* BAD: `button[contains(@id, "foo")][1]` - -* GOOD: `#actions__{{index}}__aggregator` -* BAD: `#actions__1__aggregator` - -### CSS and XPath selectors MUST NOT reference the `@data-bind` attribute - -The `@data-bind` attribute is used by KnockoutJS, a framework Magento uses to create dynamic Javascript pages. Since this `@data-bind` attribute is tied to a specific framework, it should not be used for selectors. If Magento decides to use a different framework then these `@data-bind` selectors would break.