Skip to content

Commit a070a32

Browse files
committed
magento-pangolin/magento2-functional-testing-framework#MQE-1457: [PWA] The "waitForPwaElementVisible" action does not reference the 'timeout' value set
- Adding a note regarding the correct variable to set the timeout value.
1 parent c6697d9 commit a070a32

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

src/Magento/FunctionalTestingFramework/Module/MagentoPwaWebDriver.php

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,15 @@ class MagentoPwaWebDriver extends MagentoWebDriver
1717
{
1818
/**
1919
* Wait for a PWA Element to NOT be visible using JavaScript.
20+
* Add the WAIT_TIMEOUT variable to your .env file for this action.
2021
*
2122
* @param null $selector
2223
* @param null $timeout
2324
* @throws \Exception
2425
* @return void
2526
*/
26-
public function waitForPwaElementNotVisible($selector, $timeout = null)
27+
public function waitForPwaElementNotVisible($selector, $timeout)
2728
{
28-
$timeout = $timeout ?? $this->_getConfig()['pageload_timeout'];
29-
3029
// Determine what type of Selector is used.
3130
// Then use the correct JavaScript to locate the Element.
3231
if (\Codeception\Util\Locator::isXPath($selector)) {
@@ -38,6 +37,7 @@ public function waitForPwaElementNotVisible($selector, $timeout = null)
3837

3938
/**
4039
* Wait for a PWA Element to be visible using JavaScript.
40+
* Add the WAIT_TIMEOUT variable to your .env file for this action.
4141
*
4242
* @param null $selector
4343
* @param null $timeout
@@ -46,8 +46,6 @@ public function waitForPwaElementNotVisible($selector, $timeout = null)
4646
*/
4747
public function waitForPwaElementVisible($selector, $timeout = null)
4848
{
49-
$timeout = $timeout ?? $this->_getConfig()['pageload_timeout'];
50-
5149
// Determine what type of Selector is used.
5250
// Then use the correct JavaScript to locate the Element.
5351
if (\Codeception\Util\Locator::isXPath($selector)) {

0 commit comments

Comments
 (0)