MQE-1917: ENABLE_BROWSER_LOG = false attaches JS logs to allure

soumyau · soumyau · commit 9cd889163546 · 2019-12-09T11:45:38.000-06:00
diff --git a/src/Magento/FunctionalTestingFramework/Extension/TestContextExtension.php b/src/Magento/FunctionalTestingFramework/Extension/TestContextExtension.php
@@ -182,7 +182,7 @@ public function beforeStep(\Codeception\Event\StepEvent $e)
     public function afterStep(\Codeception\Event\StepEvent $e)
     {
         $browserLog = $this->getDriver()->webDriver->manage()->getLog("browser");
-        if (getenv('ENABLE_BROWSER_LOG')) {
+        if (getenv('ENABLE_BROWSER_LOG') === 'true') {
             foreach (explode(',', getenv('BROWSER_LOG_BLACKLIST')) as $source) {
                 $browserLog = BrowserLogUtil::filterLogsOfType($browserLog, $source);
             }

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@ public function beforeStep(\Codeception\Event\StepEvent $e)`
`182`	`182`	`public function afterStep(\Codeception\Event\StepEvent $e)`
`183`	`183`	`{`
`184`	`184`	`$browserLog = $this->getDriver()->webDriver->manage()->getLog("browser");`
`185`		`- if (getenv('ENABLE_BROWSER_LOG')) {`
	`185`	`+ if (getenv('ENABLE_BROWSER_LOG') === 'true') {`
`186`	`186`	`foreach (explode(',', getenv('BROWSER_LOG_BLACKLIST')) as $source) {`
`187`	`187`	`$browserLog = BrowserLogUtil::filterLogsOfType($browserLog, $source);`
`188`	`188`	`}`