Merge pull request #113 from magento/MQE-977

imeron2433 · web-flow · commit 7a04afa88c0c · 2018-04-24T00:40:54.000+03:00
MQE-977: ErrorLogger expects source to be a log paramater
diff --git a/src/Magento/FunctionalTestingFramework/Extension/ErrorLogger.php b/src/Magento/FunctionalTestingFramework/Extension/ErrorLogger.php
@@ -50,7 +50,7 @@ public function logErrors($webDriver, $stepEvent)
         //Types available should be "server", "browser", "driver". Only care about browser at the moment.
         $browserLogEntries = $webDriver->manage()->getLog("browser");
         foreach ($browserLogEntries as $entry) {
-            if ($entry["source"] === "javascript") {
+            if (array_key_exists("source", $entry) && $entry["source"] === "javascript") {
                 $this->logError("javascript", $stepEvent, $entry);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public function logErrors($webDriver, $stepEvent)`
`50`	`50`	`//Types available should be "server", "browser", "driver". Only care about browser at the moment.`
`51`	`51`	`$browserLogEntries = $webDriver->manage()->getLog("browser");`
`52`	`52`	`foreach ($browserLogEntries as $entry) {`
`53`		`- if ($entry["source"] === "javascript") {`
	`53`	`+ if (array_key_exists("source", $entry) && $entry["source"] === "javascript") {`
`54`	`54`	`$this->logError("javascript", $stepEvent, $entry);`
`55`	`55`	`}`
`56`	`56`	`}`