diff --git a/Magento/Sniffs/Legacy/MageEntitySniff.php b/Magento/Sniffs/Legacy/MageEntitySniff.php
index 6750eec5..e0db60a8 100644
--- a/Magento/Sniffs/Legacy/MageEntitySniff.php
+++ b/Magento/Sniffs/Legacy/MageEntitySniff.php
@@ -13,11 +13,11 @@
*/
class MageEntitySniff implements Sniff
{
- /**
- * String representation of error.
- *
- * @var string
- */
+ /**
+ * String representation of error.
+ *
+ * @var string
+ */
protected $errorMessage = 'Possible Magento 2 design violation. Detected typical Magento 1.x construction "%s".';
/**
diff --git a/Magento/Sniffs/Security/IncludeFileSniff.php b/Magento/Sniffs/Security/IncludeFileSniff.php
index 28b768ea..0673f598 100644
--- a/Magento/Sniffs/Security/IncludeFileSniff.php
+++ b/Magento/Sniffs/Security/IncludeFileSniff.php
@@ -14,11 +14,11 @@
*/
class IncludeFileSniff implements Sniff
{
- /**
- * Warning violation code.
- *
- * @var string
- */
+ /**
+ * Warning violation code.
+ *
+ * @var string
+ */
protected $warningCode = 'FoundIncludeFile';
/**
@@ -93,7 +93,7 @@ public function process(File $phpcsFile, $stackPtr)
if ($hasVariable) {
$message .= ' Variables inside are insecure.';
}
- $phpcsFile->addWarning(
+ $phpcsFile->addError(
$message,
$stackPtr,
$this->warningCode,
diff --git a/Magento/Tests/Security/IncludeFileUnitTest.php b/Magento/Tests/Security/IncludeFileUnitTest.php
index 254dc842..40153cf5 100644
--- a/Magento/Tests/Security/IncludeFileUnitTest.php
+++ b/Magento/Tests/Security/IncludeFileUnitTest.php
@@ -3,6 +3,7 @@
* Copyright © Magento. All rights reserved.
* See COPYING.txt for license details.
*/
+
namespace Magento\Tests\Security;
use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest;
@@ -16,14 +17,6 @@ class IncludeFileUnitTest extends AbstractSniffUnitTest
* @inheritdoc
*/
public function getErrorList()
- {
- return [];
- }
-
- /**
- * @inheritdoc
- */
- public function getWarningList()
{
return [
3 => 1,
@@ -42,4 +35,12 @@ public function getWarningList()
34 => 1,
];
}
+
+ /**
+ * @inheritdoc
+ */
+ public function getWarningList()
+ {
+ return [];
+ }
}
diff --git a/Magento/ruleset.xml b/Magento/ruleset.xml
index e85c2930..91f4c72f 100644
--- a/Magento/ruleset.xml
+++ b/Magento/ruleset.xml
@@ -5,197 +5,398 @@
-
- 8
- warning
+
+
+ 10
+ error
-
- 8
+
+ 10
+ error
+ *.phtml
-
- 6
+
+ 10
+ error
-
- 6
+
+ 10
+ error
-
- 8
+
+ 10
+ error
-
- 6
+
+ 10
+ error
-
- 6
+
+ 10
+ error
-
- 6
+
+ 10
+ error
-
+
10
+ error
-
- 8
- warning
+
+ 10
+ error
-
- 8
+
+ 10
+ error
-
+
10
- *.phtml
+ error
-
+
10
+ error
-
- 8
+
+ 10
+ error
-
+
10
+ error
-
- 6
+
+ 10
+ error
+ *.phtml
+
+
+ 10
+ error
+
+
+
+
+ 9
+ warning
+
+
+ 9
+ warning
+
+
+ 9
+ warning
+
+
+ 9
+ warning
+
+ *.phtml
+ 9
+ warning
+
+
+ 9
+ warning
+
+
+
8
+ warning
8
-
-
- 8
warning
8
-
-
- 8
+ warning
- 6
+ 8
+ warning
+ 8
warning
- 6
-
-
- 10
- 6
+ 8
+ warning
-
- 10
+
+ 8
+ warning
-
- 6
+
+ *.phtml
+ 8
+ warning
-
+
8
+ warning
-
- 10
+
+
+
+ 7
+ warning
-
- 10
+
+ 7
+ warning
-
- 8
+
+ 7
+ warning
-
- 10
+
+ 7
+ warning
-
- 8
+
+ 7
+ warning
+
+
+ 7
+ warning
+
+
+ 7
+ warning
+
+
+ 7
+ warning
+
+
+ 7
+ warning
+
+
+ 7
+ warning
+
+
+ 0
+
+
+ 7
+ warning
+
+
+ 7
+ warning
+
+
+ 7
+ warning
- 8
+ 7
+ warning
- 8
+ 7
+ warning
-
- 8
+
+ 7
+ warning
-
- 10
+
+ 7
+ warning
-
- 10
+
+ 7
+ warning
-
- 8
+
+ 7
+ warning
-
- *.phtml
- 8
+
+ 7
+ warning
-
- 10
+
+ 7
+ warning
-
- 8
+
+
+
+ 6
+ warning
-
- *.phtml
+
6
+ warning
-
+
+ 6
+ warning
+
+
+ 6
+ warning
+
+
+ 6
+ warning
+
+
+ 6
+ warning
+
+
+ 6
+ warning
+
+
+ 6
+ warning
+
+
+
+
+
+
+
+
+ 6
+ warning
+
+
6
+ warning
-
+
6
+ warning
6
warning
-
- 8
+
+ 6
warning
-
-
-
- 10
- error
+
+ 6
+ warning
-
- 10
- error
- *.phtml
+
+ 6
+ warning
-
+
6
warning
+
-
+
6
warning
-
+
+ 6
+ warning
+
+
+ 6
+ warning
+
+
+ 6
+ warning
+
+
+ 6
+ warning
+
+
+ 0
+
+
+ 0
+
+
+ 6
+ warning
+
+
+ 6
+ warning
+
+
+
+ 6
+ warning
+
+
+ 6
+ warning
+
+
+ 6
+ warning
+
+
+ 6
+ warning
+
+
+ 6
+ warning
+
+
+ 0
+
+
+ 6
+ warning
+
+
+ 6
+ warning
+
+
+ 6
+ warning
+
+
6
+ warning
-
+
-
- 10
- error
+
+ 0
-
- 8
+
+ 6
warning
-
+
6
+ warning
-
+
6
warning
@@ -207,7 +408,45 @@
6
warning
-
- 8
+
+ 6
+ warning
+
+
+ 6
+ warning
+
+
+
+
+
+ 6
+ warning
+
+
+ 0
+
+
+ 0
+
+
+ 0
+
+
+
+
+ 5
+ warning
+
+
+ 5
+ warning
+
+
+
+
+
+ 5
+ warning