AC-1509: Remove outdated JSCS static tests from magento

Author: loginesta

.github/workflows/php.yml

@@ -75,6 +75,3 @@ jobs:
 
       - name: Run ESLint
         run: npm run eslint -- eslint/rules
-
-      - name: Run JSCS
-        run: npm run jscs eslint/rules Magento2

eslint/.eslintrc

@@ -3,6 +3,7 @@
     	"./.eslintrc-reset",
     	"./.eslintrc-magento",
     	"./.eslintrc-jquery",
-    	"./.eslintrc-misc"
+    	"./.eslintrc-misc",
+    	"./.eslintrc-jscs"
     ]
 }

eslint/.eslintrc-jscs

@@ -0,0 +1,64 @@
+{
+  "rules": {
+    "no-with": 2,
+    "space-before-function-paren": [
+      2,
+      {
+        "anonymous": "always",
+        "named": "never",
+        "asyncArrow": "always"
+      }
+    ],
+    "curly": [
+      2,
+      "all"
+    ],
+    "keyword-spacing": [
+      2,
+      {}
+    ],
+    "no-empty": [
+      2,
+      {
+        "allowEmptyCatch": true
+      }
+    ],
+    "no-mixed-spaces-and-tabs": 2,
+    "no-multiple-empty-lines": 2,
+    "no-multi-str": 2,
+    "space-unary-ops": [
+      2,
+      {
+        "words": false,
+        "nonwords": false
+      }
+    ],
+    "space-in-parens": [
+      2,
+      "never"
+    ],
+    "comma-dangle": [
+      2,
+      "never"
+    ],
+    "no-trailing-spaces": 2,
+    "comma-style": [
+      2,
+      "last"
+    ],
+    "eol-last": 2,
+    "one-var": [
+      2,
+      "always"
+    ],
+    "space-infix-ops": 2,
+    "space-before-blocks": [
+      2,
+      "always"
+    ],
+    "quotes": [
+      2,
+      "single"
+    ]
+  }
+}

eslint/rules/jquery-no-andSelf.js

@@ -31,11 +31,9 @@ module.exports = {
              * @param {Object} node - The node to check.
              */
             CallExpression: function (node) {
-                // jscs:disable requireCurlyBraces
-                if (node.callee.type !== 'MemberExpression') return;
+                if (node.callee.type !== 'MemberExpression') {return;}
 
-                if (node.callee.property.name !== 'andSelf') return;
-                // jscs:enable requireCurlyBraces
+                if (node.callee.property.name !== 'andSelf') {return;}
 
                 if (utils.isjQuery(node)) {
                     context.report({

eslint/rules/jquery-no-bind-unbind.js

@@ -31,11 +31,9 @@ module.exports = {
              * @param {Object} node - The node to check.
              */
             CallExpression: function (node) {
-                // jscs:disable requireCurlyBraces
-                if (node.callee.type !== 'MemberExpression') return;
+                if (node.callee.type !== 'MemberExpression') {return;}
 
-                if (!['bind', 'unbind'].includes(node.callee.property.name)) return;
-                // jscs:enable requireCurlyBraces
+                if (!['bind', 'unbind'].includes(node.callee.property.name)) {return;}
 
                 if (utils.isjQuery(node)) {
                     context.report({

eslint/rules/jquery-no-click-event-shorthand.js

@@ -34,11 +34,9 @@ module.exports = {
                     'mouseup', 'mousemove','mouseover', 'mouseout', 'mouseenter', 'mouseleave', 'change', 'select',
                     'submit', 'keydown', 'keypress', 'keyup', 'contextmenu', 'click'];
 
-                // jscs:disable requireCurlyBraces
-                if (node.callee.type !== 'MemberExpression') return;
+                if (node.callee.type !== 'MemberExpression') {return;}
 
-                if (!names.includes(node.callee.property.name)) return;
-                // jscs:enable requireCurlyBraces
+                if (!names.includes(node.callee.property.name)) {return;}
 
                 if (utils.isjQuery(node)) {
                     name = node.callee.property.name;

eslint/rules/jquery-no-delegate-undelegate.js

@@ -31,11 +31,9 @@ module.exports = {
              * @param {Object} node - The node to check.
              */
             CallExpression: function (node) {
-                // jscs:disable requireCurlyBraces
-                if (node.callee.type !== 'MemberExpression') return;
+                if (node.callee.type !== 'MemberExpression') {return;}
 
-                if (!['delegate', 'undelegate'].includes(node.callee.property.name)) return;
-                // jscs:enable requireCurlyBraces
+                if (!['delegate', 'undelegate'].includes(node.callee.property.name)) {return;}
 
                 if (utils.isjQuery(node)) {
                     context.report({

eslint/rules/jquery-no-event-shorthand.js

@@ -31,11 +31,9 @@ module.exports = {
                 var names = ['load', 'unload', 'error'],
                     name;
 
-                // jscs:disable requireCurlyBraces
-                if (node.callee.type !== 'MemberExpression') return;
+                if (node.callee.type !== 'MemberExpression') {return;}
 
-                if (!names.includes(node.callee.property.name)) return;
-                // jscs:enable requireCurlyBraces
+                if (!names.includes(node.callee.property.name)) {return;}
 
                 if (utils.isjQuery(node)) {
                     name = node.callee.property.name;

eslint/rules/jquery-no-size.js

@@ -31,11 +31,9 @@ module.exports = {
              * @param {Object} node - The node to check.
              */
             CallExpression: function (node) {
-                // jscs:disable requireCurlyBraces
-                if (node.callee.type !== 'MemberExpression') return;
+                if (node.callee.type !== 'MemberExpression') {return;}
 
-                if (node.callee.property.name !== 'size') return;
-                // jscs:enable requireCurlyBraces
+                if (node.callee.property.name !== 'size') {return;}
 
                 if (utils.isjQuery(node)) {
                     context.report({

eslint/rules/jquery-no-trim.js

@@ -29,13 +29,11 @@ module.exports = {
              * @param {Object} node - The node to check.
              */
             CallExpression: function (node) {
-                // jscs:disable requireCurlyBraces
-                if (node.callee.type !== 'MemberExpression') return;
+                if (node.callee.type !== 'MemberExpression') {return;}
 
-                if (node.callee.object.name !== '$') return;
+                if (node.callee.object.name !== '$') {return;}
 
-                if (node.callee.property.name !== 'trim') return;
-                // jscs:enable requireCurlyBraces
+                if (node.callee.property.name !== 'trim') {return;}
 
                 context.report({
                     node: node,