AC-1156: AC-1156: Move custom eslint tests to magento-coding-standard repo

- Fix typo in README and add missing 'void' on unit tests

Author: loginesta

Magento2/Tests/Eslint/AbstractEslintTestCase.php

@@ -20,7 +20,7 @@ abstract class AbstractEslintTestCase extends TestCase
      * @param string $testFile
      * @param array $expectedMessages
      */
-    protected function assertFileContainsError(string $testFile, array $expectedMessages)
+    protected function assertFileContainsError(string $testFile, array $expectedMessages): void
     {
         exec(
             'npm run eslint -- Magento2/Tests/Eslint/' . $testFile,

Magento2/Tests/Eslint/AndSelfTest.php

@@ -14,7 +14,7 @@
  */
 class AndSelfTest extends AbstractEslintTestCase
 {
-    public function testExecute()
+    public function testExecute(): void
     {
         $this->assertFileContainsError(
             'AndSelfTest.js',

Magento2/Tests/Eslint/BindUnbindTest.php

@@ -14,7 +14,7 @@
  */
 class BindUnbindTest extends AbstractEslintTestCase
 {
-    public function testExecute()
+    public function testExecute(): void
     {
         $this->assertFileContainsError(
             'BindUnbindTest.js',

Magento2/Tests/Eslint/ClickEventShorthandTest.php

@@ -14,7 +14,7 @@
  */
 class ClickEventShorthandTest extends AbstractEslintTestCase
 {
-    public function testExecute()
+    public function testExecute(): void
     {
         $this->assertFileContainsError(
             'ClickEventShorthand.js',

Magento2/Tests/Eslint/DelegateUndelegateTest.php

@@ -14,7 +14,7 @@
  */
 class DelegateUndelegateTest extends AbstractEslintTestCase
 {
-    public function testExecute()
+    public function testExecute(): void
     {
         $this->assertFileContainsError(
             'DelegateUndelegateTest.js',

Magento2/Tests/Eslint/EventShorthandTest.php

@@ -14,7 +14,7 @@
  */
 class EventShorthandTest extends AbstractEslintTestCase
 {
-    public function testExecute()
+    public function testExecute(): void
     {
         $this->assertFileContainsError(
             'EventShorthandTest.js',

Magento2/Tests/Eslint/SizeTest.php

@@ -14,7 +14,7 @@
  */
 class SizeTest extends AbstractEslintTestCase
 {
-    public function testExecute()
+    public function testExecute(): void
     {
         $this->assertFileContainsError(
             'SizeTest.js',

Magento2/Tests/Eslint/TrimTest.php

@@ -14,7 +14,7 @@
  */
 class TrimTest extends AbstractEslintTestCase
 {
-    public function testExecute()
+    public function testExecute(): void
     {
         $this->assertFileContainsError(
             'TrimTest.js',

README.md

@@ -107,9 +107,9 @@ You need to run the following command to install all the necessary packages desc
 npm install
 ```
 
-After that, you can just execute the ESLint tests simply running:
+After that, you can just execute ESLint as follows:
 ```bash
-npm run eslint -- eslint/rules
+npm run eslint -- path/to/analyze
 ```
 ## License