AC-1102: Static test to verify self-closing tags for non-void html elements

xmav · xmav · commit 592dcfc82508 · 2021-09-14T14:26:10.000-05:00
- add unit test for new sniff
diff --git a/Magento2/Sniffs/Html/HtmlSelfClosingTagsSniff.php b/Magento2/Sniffs/Html/HtmlSelfClosingTagsSniff.php
@@ -75,7 +75,7 @@ public function process(File $phpcsFile, $stackPtr)
                         'Avoid using self-closing tag with non-void html element'
                         . ' - "' . $match[0]  . PHP_EOL,
                         null,
-                        'HtmlTemplates.Tag.SelfClosing'
+                        'HtmlSelfClosingNonVoidTag'
                     );
                 }
             }
diff --git a/Magento2/Tests/Html/HtmlSelfClosingTagsUnitTest.1.inc b/Magento2/Tests/Html/HtmlSelfClosingTagsUnitTest.1.inc
@@ -0,0 +1,45 @@
+<!--
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+-->
+
+<html>
+    <head>
+        <base/>
+        <link/>
+    </head>
+    <body>
+        <area alt=""/>
+        <br/>
+        <table>
+            <colgroup>
+                <col/>
+            </colgroup>
+        </table>
+        <embed/>
+        <hr/>
+        <img src="" alt=""/>
+        <input type="text" id="test_input"/>
+        <keygen/>
+        <link/>
+        <meta/>
+        <param name="" value=""/>
+        <video>
+            <source/>
+            <track src=""/>
+        </video>
+        <wbr/>
+
+        <label for="test_input"/>
+        <style type="text/css"/>
+        <div/>
+        <span/>
+        <text/>
+        <render/>
+        <each/>
+        <translate/>
+        <scope/>
+    </body>
+</html>
diff --git a/Magento2/Tests/Html/HtmlSelfClosingTagsUnitTest.php b/Magento2/Tests/Html/HtmlSelfClosingTagsUnitTest.php
@@ -0,0 +1,27 @@
+<?php
+/**
+ * Copyright © Magento. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento2\Tests\Html;
+
+use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest;
+
+class HtmlSelfClosingTagsUnitTest extends AbstractSniffUnitTest
+{
+    /**
+     * @inheritdoc
+     */
+    public function getErrorList()
+    {
+        return [1 => 9];
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getWarningList()
+    {
+        return [];
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ public function process(File $phpcsFile, $stackPtr)`
`75`	`75`	`'Avoid using self-closing tag with non-void html element'`
`76`	`76`	`. ' - "' . $match[0] . PHP_EOL,`
`77`	`77`	`null,`
`78`		`- 'HtmlTemplates.Tag.SelfClosing'`
	`78`	`+ 'HtmlSelfClosingNonVoidTag'`
`79`	`79`	`);`
`80`	`80`	`}`
`81`	`81`	`}`