Skip to content

April 17, 2019 #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
buskamuza opened this issue Apr 10, 2019 · 5 comments
Closed

April 17, 2019 #140

buskamuza opened this issue Apr 10, 2019 · 5 comments
Labels
meeting notes Topic requests and notes from meetings

Comments

@buskamuza
Copy link
Contributor

Please add your topic as a comment to the issue. Use following format:
Topic description and link to PR, if any (duration in min)

Meeting Notes

  • note one...

Recording: TBD

@buskamuza buskamuza added the meeting notes Topic requests and notes from meetings label Apr 10, 2019
@orlangur
Copy link
Contributor

@buskamuza @sidolov @ishakhsuvarov let's discuss and document lack of Windows support (and compatibility) somewhere to not waste time on issues and pull requests similar to magento/magento2#22275 anymore.

@AlexMaxHorkun
Copy link
Contributor

Standard futures (deferred) for async operations in Magento,
#71
15 min

@lenaorobei
Copy link
Contributor

lenaorobei commented Apr 16, 2019

5.16. If a method uses system resources (such as files, sockets, streams, etc.), the code MUST be wrapped with a try block and the corresponding finally block. In the finally sections, all resources SHOULD be properly released.

@melnikovi
Copy link
Member

melnikovi commented Apr 17, 2019

Need to confirm with PO if we can abandon support of Windows as there are still developers who use windows as environment. @orlangur will create proposal with pros and cons for each option.

Deferred proposal from @AlexMaxHorkun

  • Include link to prototype to the proposal (put code in the architecture public repo)
  • Add review of interfaces of existing libraries, with pros and cons

Wrapping system resources with try catch

  • Agreed to add the the check that will work for now for new and changed files
  • Need a follow up proposal what to do with builds fails on changed files because of existing issues

Review #136 offline

@orlangur
Copy link
Contributor

@buskamuza can we have a recording here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meeting notes Topic requests and notes from meetings
Projects
None yet
Development

No branches or pull requests

5 participants