Skip to content

Commit 1950950

Browse files
authored
Merge pull request #92 from larsroettig/patch-1
Proposal: Using phpro/grumphp for local quality check
2 parents 2b9033c + 1f7c649 commit 1950950

File tree

1 file changed

+78
-0
lines changed

1 file changed

+78
-0
lines changed

design-documents/grumphp_check.md

Lines changed: 78 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,78 @@
1+
# Using phpro/grumphp for local quality check
2+
3+
4+
## Why?
5+
As a developer, you need fast feedback if you working on a pull request.
6+
Currently, you get feedback from Travis after hours or days. With GrumPHP, the code can be quickly checked on every commit.
7+
8+
## Benefits:
9+
- Quik feedback for developers
10+
- Better commits (fewer `fix phpcs style` commits)
11+
12+
Sample Config:
13+
```yml
14+
parameters:
15+
bin_dir: "./vendor/bin"
16+
git_dir: "."
17+
hooks_dir: ~
18+
hooks_preset: local
19+
stop_on_failure: false
20+
ignore_unstaged_changes: false
21+
ascii:
22+
succeeded: ~
23+
failed: ~
24+
tasks:
25+
phpversion:
26+
project: '7.1'
27+
xmllint:
28+
ignore_patterns: ["src/dev"]
29+
yamllint:
30+
ignore_patterns: ["src/dev"]
31+
securitychecker:
32+
lockfile: ./src/composer.lock
33+
format: ~
34+
end_point: ~
35+
timeout: ~
36+
run_always: false
37+
git_blacklist:
38+
keywords:
39+
- "die("
40+
- "var_dump("
41+
- "print_r("
42+
- "var_export("
43+
- "exit;"
44+
whitelist_patterns:
45+
- /^src\/app\/(.*)/
46+
triggered_by: ['php']
47+
phpmnd:
48+
directory: ./src/app/code
49+
whitelist_patterns: []
50+
exclude: []
51+
exclude_name: []
52+
exclude_path: []
53+
extensions: []
54+
hint: false
55+
ignore_numbers: []
56+
ignore_strings: []
57+
strings: false
58+
triggered_by: ['php']
59+
phpcs:
60+
standard: "./src/dev/tests/static/framework/Magento/ruleset.xml"
61+
severity: ~
62+
error_severity: ~
63+
warning_severity: 6
64+
tab_width: ~
65+
report: summary
66+
report_width: ~
67+
whitelist_patterns:
68+
- /^src\/app\/code\/(.*)/
69+
encoding: ~
70+
ignore_patterns: []
71+
sniffs: []
72+
triggered_by: [php]
73+
phpunit:
74+
config_file: ./dev/tests/phpunit-no-coverage.xml
75+
testsuite: ~
76+
group: []
77+
always_execute: false
78+
```

0 commit comments

Comments
 (0)