Skip to content

Placeholders correction #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sivaschenko opened this issue Aug 11, 2020 · 1 comment · Fixed by magento/magento2#29484
Closed

Placeholders correction #1746

sivaschenko opened this issue Aug 11, 2020 · 1 comment · Fixed by magento/magento2#29484
Assignees
@sivaschenko
Labels
Priority: P1 Needs to be fixed before any other issues Progress: done Severity: S1 Affects critical data or functionality and forces users to employ a workaround
Milestone
2.1.0

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Aug 11, 2020 •
edited
Loading

  • ui-select empty options placeholder should be corrected
  • keyword field placeholder should be corrected

Steps to Reproduce 1

  1. Open Media Gallery
  2. Expand filter section
  3. Open any ui-select filter

Expected Result 1

Correct placeholder text is displayed when no options are loaded

Steps to Reproduce 2

  1. Open Media Gallery
  2. Edit details for any image
  3. See placeholder on the field preceding "Add New Tag" button

Expected Result 2

The placeholder should be "New Tag" (instead of "New Keyword")
@m2-assistant
Copy link

m2-assistant bot commented Aug 11, 2020

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

@sivaschenko sivaschenko self-assigned this Aug 11, 2020
@sivaschenko sivaschenko mentioned this issue Aug 11, 2020
Merged
4 tasks
@sivaschenko sivaschenko added Priority: P1 Needs to be fixed before any other issues Severity: S1 Affects critical data or functionality and forces users to employ a workaround labels Aug 11, 2020
@lenaorobei lenaorobei added this to the 2.1.0 milestone Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sivaschenko sivaschenko

Labels
Priority: P1 Needs to be fixed before any other issues Progress: done Severity: S1 Affects critical data or functionality and forces users to employ a workaround
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

magento/adobe-stock-integration#1746: Corrected placeholders
2 participants
@sivaschenko @lenaorobei