Skip to content

Commit 93c1f3c

Browse files
validation: Fix names of internal SDL rules (graphql#2448)
Not a breaking change since these rules are internal.
1 parent 7a5e733 commit 93c1f3c

7 files changed

+14
-14
lines changed

src/validation/__tests__/KnownArgumentNamesRule-test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { buildSchema } from '../../utilities/buildASTSchema';
66

77
import {
88
KnownArgumentNamesRule,
9-
KnownArgumentNamesOnDirectives,
9+
KnownArgumentNamesOnDirectivesRule,
1010
} from '../rules/KnownArgumentNamesRule';
1111

1212
import { expectValidationErrors, expectSDLValidationErrors } from './harness';
@@ -22,7 +22,7 @@ function expectValid(queryStr) {
2222
function expectSDLErrors(sdlStr, schema) {
2323
return expectSDLValidationErrors(
2424
schema,
25-
KnownArgumentNamesOnDirectives,
25+
KnownArgumentNamesOnDirectivesRule,
2626
sdlStr,
2727
);
2828
}

src/validation/__tests__/ProvidedRequiredArgumentsRule-test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { buildSchema } from '../../utilities/buildASTSchema';
66

77
import {
88
ProvidedRequiredArgumentsRule,
9-
ProvidedRequiredArgumentsOnDirectives,
9+
ProvidedRequiredArgumentsOnDirectivesRule,
1010
} from '../rules/ProvidedRequiredArgumentsRule';
1111

1212
import { expectValidationErrors, expectSDLValidationErrors } from './harness';
@@ -22,7 +22,7 @@ function expectValid(queryStr) {
2222
function expectSDLErrors(sdlStr, schema) {
2323
return expectSDLValidationErrors(
2424
schema,
25-
ProvidedRequiredArgumentsOnDirectives,
25+
ProvidedRequiredArgumentsOnDirectivesRule,
2626
sdlStr,
2727
);
2828
}

src/validation/rules/KnownArgumentNamesRule.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@ export function KnownArgumentNamesRule(context: ValidationContext): ASTVisitor;
1212
/**
1313
* @internal
1414
*/
15-
export function KnownArgumentNamesOnDirectives(
15+
export function KnownArgumentNamesOnDirectivesRule(
1616
context: ValidationContext | SDLValidationContext,
1717
): ASTVisitor;

src/validation/rules/KnownArgumentNamesRule.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import {
2323
*/
2424
export function KnownArgumentNamesRule(context: ValidationContext): ASTVisitor {
2525
return {
26-
...KnownArgumentNamesOnDirectives(context),
26+
...KnownArgumentNamesOnDirectivesRule(context),
2727
Argument(argNode) {
2828
const argDef = context.getArgument();
2929
const fieldDef = context.getFieldDef();
@@ -48,7 +48,7 @@ export function KnownArgumentNamesRule(context: ValidationContext): ASTVisitor {
4848
/**
4949
* @internal
5050
*/
51-
export function KnownArgumentNamesOnDirectives(
51+
export function KnownArgumentNamesOnDirectivesRule(
5252
context: ValidationContext | SDLValidationContext,
5353
): ASTVisitor {
5454
const directiveArgs = Object.create(null);

src/validation/rules/ProvidedRequiredArgumentsRule.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ export function ProvidedRequiredArgumentsRule(
1414
/**
1515
* @internal
1616
*/
17-
export function ProvidedRequiredArgumentsOnDirectives(
17+
export function ProvidedRequiredArgumentsOnDirectivesRule(
1818
context: ValidationContext | SDLValidationContext,
1919
): ASTVisitor;

src/validation/rules/ProvidedRequiredArgumentsRule.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export function ProvidedRequiredArgumentsRule(
2727
context: ValidationContext,
2828
): ASTVisitor {
2929
return {
30-
...ProvidedRequiredArgumentsOnDirectives(context),
30+
...ProvidedRequiredArgumentsOnDirectivesRule(context),
3131
Field: {
3232
// Validate on leave to allow for deeper errors to appear first.
3333
leave(fieldNode) {
@@ -59,7 +59,7 @@ export function ProvidedRequiredArgumentsRule(
5959
/**
6060
* @internal
6161
*/
62-
export function ProvidedRequiredArgumentsOnDirectives(
62+
export function ProvidedRequiredArgumentsOnDirectivesRule(
6363
context: ValidationContext | SDLValidationContext,
6464
): ASTVisitor {
6565
const requiredArgsMap = Object.create(null);

src/validation/specifiedRules.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ import { UniqueDirectivesPerLocationRule } from './rules/UniqueDirectivesPerLoca
6060
// Spec Section: "Argument Names"
6161
import {
6262
KnownArgumentNamesRule,
63-
KnownArgumentNamesOnDirectives,
63+
KnownArgumentNamesOnDirectivesRule,
6464
} from './rules/KnownArgumentNamesRule';
6565

6666
// Spec Section: "Argument Uniqueness"
@@ -72,7 +72,7 @@ import { ValuesOfCorrectTypeRule } from './rules/ValuesOfCorrectTypeRule';
7272
// Spec Section: "Argument Optionality"
7373
import {
7474
ProvidedRequiredArgumentsRule,
75-
ProvidedRequiredArgumentsOnDirectives,
75+
ProvidedRequiredArgumentsOnDirectivesRule,
7676
} from './rules/ProvidedRequiredArgumentsRule';
7777

7878
// Spec Section: "All Variable Usages Are Allowed"
@@ -142,8 +142,8 @@ export const specifiedSDLRules = Object.freeze([
142142
KnownDirectivesRule,
143143
UniqueDirectivesPerLocationRule,
144144
PossibleTypeExtensionsRule,
145-
KnownArgumentNamesOnDirectives,
145+
KnownArgumentNamesOnDirectivesRule,
146146
UniqueArgumentNamesRule,
147147
UniqueInputFieldNamesRule,
148-
ProvidedRequiredArgumentsOnDirectives,
148+
ProvidedRequiredArgumentsOnDirectivesRule,
149149
]);

0 commit comments

Comments
 (0)