Cherry-pick to master: [rom_ext] Disable compiler jump guards #28897
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
The compiler `guards` feature is meant as a control flow integrity feature that inserts `unimp` sequences around branches to protect against instruction skips. Unfortunately, the ROM_EXT has grown perilously close to its size limit and the `guards` feature results in an approximately 12% tax on code size. By turning this feature off, we save about 5700 bytes of code space. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit 753aeff)
siemen11
force-pushed
the
guards_compiler_option_removal_cherry
branch
from
662ae94 to
1dda77b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler
guardsfeature is meant as a control flow integrity feature that insertsunimpsequences around branches to protect against instruction skips.Unfortunately, the ROM_EXT has grown perilously close to its size limit and the
guardsfeature results in an approximately 12% tax on code size. By turning this feature off, we save about 5700 bytes of code space.(see #26636)
(the commit was amended to remove the option from the enabled_features list of the toolchain since it was already out of bazelrc)