Backport 26169 ([rom_ext] fix CDI_* cert update bug ) #28891
+233
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamaury
requested review from
jwnrt and
timothytrippel
and removed request for
a team
pamaury
force-pushed
the
backport_26169
branch
from
668f9df to
d547abb
Compare
Contributor
Author
|
The rust harness needed some nontrivial fixes due to the console changes introduces in #28805. I added a commit to make them so that it clear which changes come from this versus the original test. |
pamaury
force-pushed
the
backport_26169
branch
from
31287ee to
df065fd
Compare
We split the "print_certs" test out into a separate opentitan_binary target so that it can be reused amongst many tests. Signed-off-by: Tim Trippel <[email protected]> (cherry picked from commit b805ccd)
There are two flavors of ROM_EXT: 1. one that uses X.509 DICE cert encodings, and 2. one that uses CWT DICE cert encodings. If you run one first, you should be able to run the other later and the ROM_EXT should seemlessly update the CDI certs. This adds a test to check this behavior works as intended. Signed-off-by: Tim Trippel <[email protected]> (cherry picked from commit 8a2ac65)
Signed-off-by: Amaury Pouly <[email protected]>
pamaury
force-pushed
the
backport_26169
branch
from
df065fd to
315ca49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #26169. One commit is not needed because it was backported in #27714. Nevertheless this backport is bit cursed because on master, the dice chain was moved to its file
dice_chain.cbefore this change, whereas on earlgrey_1.0.0 it was moved after. Even after that, the diff still has a conflict because the debug message on earlgrey_1.0.0 iswarning: CDI_1 certificate not valid. updating\r\nwhile it isCDI_1 certificate not valid. updating\r\non master. Scrolling through the history, I found that #27286 manually cherry-picked #25279 but did not cherry-picked the inclusion of thewarning:prefix for some reason. Since this prefix is used by the harness and since all other strings that with eitherwarning:orerror:, it makes sense to change the format to include this prefix as well which is what I did.