Swap root-relative labels for absolute ones #28876
Conversation
This is necessary when used as a nonroot bazel module. Change-Id: Ic5a320b42722bd765ded9d1ce7453f5ce39797eb Signed-off-by: Amit Kumar-Hermosillo <[email protected]>
| "emulation": { | ||
| "otp": "em00", | ||
| "ca_data": "@//sw/device/silicon_creator/manuf/keys/fake:ca_data", | ||
| "ca_data": "@lowrisc_opentitan//sw/device/silicon_creator/manuf/keys/fake:ca_data", |
There was a problem hiding this comment.
I'm sure there are many more uses of root-relative labels in the codebase that should be fixed (for example, the dice_libs immediately below this line).
There was a problem hiding this comment.
I think those might be fine? specifically, it was the @// that was causing problems, since that goes out to the root module, not just the root of this repo.
Doing a quick search, it seems like there is a few more of those though. If I globally replace them all, is the CI good enough to catch a potential regression?
There was a problem hiding this comment.
I think those might be fine? specifically, it was the
@//that was causing problems, since that goes out to the root module, not just the root of this repo.Doing a quick search, it seems like there is a few more of those though. If I globally replace them all, is the CI good enough to catch a potential regression?
Its up to you how you want to handle this. My comment was more of a warning about what to expect than a request to go fix everything. If you'd like to submit this PR to get past your immediate issue, that's ok by me.
2 participants
This is necessary when used as a nonroot bazel module. Follow-on to #28144 (ie, I missed a few)