Create NetStandard 2.0 library

Split the library in two parts: One runtime library which targets .NET Standard 2.0 and one test library that targets .NET 6 and consumes the runtime library. This way, Xunit and other test-related libraries are not required to be deployed when referencing Look#.

It is recommended to use the lowest/oldest .NET Standard version which under which your library can execute to maximize compatibility.

In addition, add support for setting custom headers on a request-by-request basis. This is required because Looker requires the User-Agent header to be present when acquiring an embed session.

Author: Kristoffer Sjöberg

csharp/.gitignore

@@ -0,0 +1 @@
+.vs

csharp/csharp.csproj renamed to csharp/LookerSdk.Tests/LookerSdk.Tests.csproj

@@ -2,17 +2,24 @@
   <PropertyGroup>
     <TargetFramework>net6.0</TargetFramework>
     <IsPackable>false</IsPackable>
-    <GenerateTargetFrameworkAttribute>false</GenerateTargetFrameworkAttribute>
     <LangVersion>10</LangVersion>
+    <OutputType>Library</OutputType>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">
-    <OutputPath>bin\Debug/net6.0/</OutputPath>
+    <OutputPath>bin\Debug</OutputPath>
   </PropertyGroup>
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.5.0" />
-    <PackageReference Include="xunit" Version="2.4.1" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="2.4.2" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
+    <PackageReference Include="xunit" Version="2.6.1" />
+    <PackageReference Include="xunit.extensibility.execution" Version="2.6.1" />
     <PackageReference Include="coverlet.collector" Version="1.2.0" />
     <PackageReference Include="ini-parser-netstandard" Version="2.5.2" />
+    <PackageReference Include="xunit.runner.visualstudio" Version="2.5.3">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
+  </ItemGroup>
+  <ItemGroup>
+    <ProjectReference Include="..\LookerSdk\LookerSdk.csproj" />
   </ItemGroup>
 </Project>

csharp/rtl.Tests/ApiMethodsTests.cs renamed to csharp/LookerSdk.Tests/rtl.Tests/ApiMethodsTests.cs

@@ -44,4 +44,4 @@ public async Task GetHtmlUrlTest()
             Assert.Contains(_config.HtmlTestContent, actual);
         }
     }
-}
+}

csharp/rtl.Tests/ApiSettingsTests.cs renamed to csharp/LookerSdk.Tests/rtl.Tests/ApiSettingsTests.cs

@@ -1,10 +1,9 @@
 using System;
 using System.Net;
 using System.Net.Http;
-using System.Text.Json;
 using System.Threading.Tasks;
 using Looker.RTL;
-using Microsoft.VisualStudio.TestPlatform.CommunicationUtilities.ObjectModel;
+using Newtonsoft.Json;
 using Xunit;
 using Xunit.Abstractions;
 
@@ -62,7 +61,7 @@ public async Task GetJsonUrlTest()
             var content = actual.Body.ToString();
             Assert.NotNull(content);
             Assert.Contains("looker_release_version", content);
-            var json = JsonSerializer.Deserialize<Values>(content);
+            var json = JsonConvert.DeserializeObject<Values>(content);
             Assert.Equal(json.Keys, _versionKeys);
         }