Fix jumps of unstyled content and test freezes, credit to @simonihmig, fixes #44 #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonihmig
reviewed
Mar 26, 2022
addon/-private/modifier.ts
Outdated
| this._promiseResolveHasBeenInstalled(); | ||
| this._promiseResolveHasBeenInstalled = undefined; | ||
| } | ||
| __didResizeHandler(): void { |
Collaborator
There was a problem hiding this comment.
I had to look a couple of times to realize this hasn't the same name like the other method. Maybe call this _didResizeHandlerSync instead?
| SIZES_HEIGHT_DEFAULT, | ||
| } from 'ember-element-query'; | ||
| import { inject as service } from '@ember/service'; | ||
| import { waitFor } from '@ember/test-waiters'; |
Collaborator
There was a problem hiding this comment.
It seems this is unused now, so you can remove from dependencies.
simonihmig
approved these changes
Mar 27, 2022
Collaborator
simonihmig
left a comment
simonihmig
left a comment
There was a problem hiding this comment.
Looks good!
CI didn't run before, it was disabled due to inactivity. I enabled it, so maybe you should force push again to trigger it!?
…fixes #44: address PR feedback
lolmaus
force-pushed
the
issue-44-jumps-and-freezes
branch
from
5c8d49d to
580faf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44