Avoid to store nil values for version_type, version and routing

Adding `version => nil` is a change in behaviour because, actually it's never added, so this commit respect the existing logic, do not add event's keys that are empty

Co-authored-by: Ry Biesemeyer <[email protected]>

Author: andsel

lib/logstash/outputs/elasticsearch.rb

@@ -557,7 +557,8 @@ def common_event_params(event)
     params[:version] = resolve_version(event, event_version)
     params[:version_type] = resolve_version_type(event, event_version_type)
 
-    params
+    # purge nil valued key-value pairs
+    params.compact
   end
 
   def resolve_version(event, event_version)

spec/unit/outputs/elasticsearch_spec.rb

@@ -304,7 +304,7 @@
 
         context "when the event DOESN'T contain an integration metadata version" do
           it "plugin's default id mechanism is used" do
-            expect(subject.send(:event_action_tuple, event)[1]).to include(:version => nil)
+            expect(subject.send(:event_action_tuple, event)[1]).to_not include(:version)
           end
         end
       end
@@ -338,7 +338,7 @@
 
         context "when the event DOESN'T contain an integration metadata version_type" do
           it "plugin's default id mechanism is used" do
-            expect(subject.send(:event_action_tuple, event)[1]).to include(:version_type => nil)
+            expect(subject.send(:event_action_tuple, event)[1]).to_not include(:version_type)
           end
         end
       end
@@ -372,7 +372,7 @@
 
         context "when the event DOESN'T contain an integration metadata routing" do
           it "plugin's default id mechanism is used" do
-            expect(subject.send(:event_action_tuple, event)[1]).to include(:routing => nil)
+            expect(subject.send(:event_action_tuple, event)[1]).to_not include(:routing)
           end
         end
       end