Fix failing tests #309
Merged
Fix failing tests #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the fix on multiline codec (logstash-plugins/logstash-codec-multiline#70) introduced to avoid sharing of codec across multiple threads, it started to make fail this test that leveraged that shared instance to tracing the codec calls. The multithreading nature of the test and the lack of synchornizaion to access the IdentityCodecMap led to multiple threads overwrite of the codec instances. This overwrite cleans the history of previous tracked calls making it failing. This commit fixes it giving to che #clone a method a simil-singleton functionality, to don't loose the list of tracked calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
This PR fixes some failing tests on
mainThere are two failures that this PR fixes:
hostorpathattribute running against Logstash 8, which by default has ECS enabled.The fix consisted in surrounding the test with the ECS harness and use the
ecs_selectto refer attributes with proper name.having timed_out, the codec is auto flushed. It presented 2 problems:subject.stopto trigger theauto_flushcall (called byexit_flushmethod).IdentityMapCodecused a shared codec. When this behavior was removed the test, that engage multiple threads, exposed a problem of overwriting of codec reference. This overwriting drove to the lost of data, used in test logic. The fix consists in clone redefinition to make it almost a singleton.Why is it important/What is the impact to the user?
Make the test green increase the confidence in the code base.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature worksRelated issues