Show tooltip for K8s support in API coverage table #315
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying localstack-docs with
|
| Latest commit: |
c92faaf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dae2effc.localstack-docs.pages.dev |
| Branch Preview URL: | https://unc-69-improve-wording-for-k.localstack-docs.pages.dev |
nik-localstack
force-pushed
the
UNC-69-improve-wording-for-k8s-support-coverage
branch
2 times, most recently
from
3c5a2bc to
a858a4a
Compare
nik-localstack
requested review from
HarshCasper,
quetzalliwrites and
remotesynth
as code owners
remotesynth
approved these changes
Nov 12, 2025
Collaborator
|
Is this still in draft mode @nik-localstack, or are we good to merge? 🐱 |
Contributor
Author
|
Still in draft, I accidentally requested for your review, sorry. |
simonrw
reviewed
Nov 12, 2025
| id: 'k8s_support', | ||
| accessorFn: (row) => row[Object.keys(row)[0]].k8s_test_suite, | ||
| header: () => 'Tested on Kubernetes', | ||
| header: () => 'Verified on Kubernetes', |
Contributor
There was a problem hiding this comment.
For other reviewers: this is a crucial part of the motivation for this change. We want to add clarity on what this column means, and the title should make it clear, and the tooltip provides extra context.
simonrw
reviewed
Nov 12, 2025
nik-localstack
force-pushed
the
UNC-69-improve-wording-for-k8s-support-coverage
branch
from
a858a4a to
a23f25c
Compare
nik-localstack
force-pushed
the
UNC-69-improve-wording-for-k8s-support-coverage
branch
from
a23f25c to
c92faaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the working for the "Tested in k8s" column of API coverage docs for AWS services.
See how it behaves here.
https://unc-69-improve-wording-for-k.localstack-docs.pages.dev/aws/services/batch/#api-coverage
It requires a few seconds before showing the message but that's how the behavior of these tooltips is.