diff --git a/flang/lib/Lower/OpenMP/DataSharingProcessor.cpp b/flang/lib/Lower/OpenMP/DataSharingProcessor.cpp index d3e892be74fd8..343eb1b732b69 100644 --- a/flang/lib/Lower/OpenMP/DataSharingProcessor.cpp +++ b/flang/lib/Lower/OpenMP/DataSharingProcessor.cpp @@ -190,12 +190,12 @@ void DataSharingProcessor::insertLastPrivateCompare(mlir::Operation *op) { for (const omp::Clause &clause : clauses) { if (clause.id != llvm::omp::OMPC_lastprivate) continue; - // TODO: Add lastprivate support for simd construct - if (mlir::isa(op)) { + if (mlir::isa(op) || + mlir::isa(op)) { // Update the original variable just before exiting the worksharing // loop. Conversion as follows: // - // omp.wsloop { omp.wsloop { + // omp.wsloop / omp.simd { omp.wsloop / omp.simd { // omp.loop_nest { omp.loop_nest { // ... ... // store ===> store diff --git a/flang/test/Lower/OpenMP/simd.f90 b/flang/test/Lower/OpenMP/simd.f90 index bdc6a1eef0156..3b2aeceb4c3f9 100644 --- a/flang/test/Lower/OpenMP/simd.f90 +++ b/flang/test/Lower/OpenMP/simd.f90 @@ -241,3 +241,36 @@ subroutine simd_with_nontemporal_clause(n) end do !$OMP END SIMD end subroutine + +!CHECK-LABEL: func.func @_QPlastprivate_with_simd() { +subroutine lastprivate_with_simd + +!CHECK: %[[VAR_SUM:.*]] = fir.alloca f32 {bindc_name = "sum", uniq_name = "_QFlastprivate_with_simdEsum"} +!CHECK: %[[VAR_SUM_DECLARE:.*]]:2 = hlfir.declare %[[VAR_SUM]] {{.*}} +!CHECK: %[[VAR_SUM_PINNED:.*]] = fir.alloca f32 {bindc_name = "sum", pinned, uniq_name = "_QFlastprivate_with_simdEsum"} +!CHECK: %[[VAR_SUM_PINNED_DECLARE:.*]]:2 = hlfir.declare %[[VAR_SUM_PINNED]] {{.*}} + + implicit none + integer :: i + real :: sum + + +!CHECK: omp.simd { +!CHECK: omp.loop_nest (%[[ARG:.*]]) : i32 = ({{.*}} to ({{.*}}) inclusive step ({{.*}}) { +!CHECK: %[[ADD_RESULT:.*]] = arith.addi {{.*}} +!CHECK: %[[ADD_RESULT_CONVERT:.*]] = fir.convert %[[ADD_RESULT]] : (i32) -> f32 +!CHECK: hlfir.assign %[[ADD_RESULT_CONVERT]] to %[[VAR_SUM_PINNED_DECLARE]]#0 : f32, !fir.ref +!CHECK: %[[SELECT_RESULT:.*]] = arith.select {{.*}}, {{.*}}, {{.*}} : i1 +!CHECK: fir.if %[[SELECT_RESULT]] { +!CHECK: %[[LOADED_SUM:.*]] = fir.load %[[VAR_SUM_PINNED_DECLARE]]#0 : !fir.ref +!CHECK: hlfir.assign %[[LOADED_SUM]] to %[[VAR_SUM_DECLARE]]#0 : f32, !fir.ref +!CHECK: } +!CHECK: omp.yield +!CHECK: } +!CHECK: omp.terminator +!CHECK: } + !$omp simd lastprivate(sum) + do i = 1, 100 + sum = i + 1 + end do +end subroutine