Skip to content

Conversation

@brad0
Copy link
Contributor

@brad0 brad0 commented Mar 16, 2024

No description provided.

@brad0 brad0 requested a review from wzssyqa March 16, 2024 07:00
@wzssyqa
Copy link
Contributor

wzssyqa commented Mar 16, 2024

Go ahead please.
I left these lines as I thought that they will be useful if we'd like to support -mabicalls -mno-shared in future.

@brad0
Copy link
Contributor Author

brad0 commented Mar 16, 2024

Go ahead please. I left these lines as I thought that they will be useful if we'd like to support -mabicalls -mno-shared in future.

It's not that I would try to dissuade you from adding support if desirable. It's just as MaskRay said usually code is not left in like that. You can always re-add it as necessary.

@brad0 brad0 merged commit a02b79f into llvm:main Mar 16, 2024
@brad0 brad0 deleted the mips_clean branch March 16, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants