From 619f2e342bd332af3222e0fcd36a8c5a27fc2d05 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Mon, 29 Jan 2024 11:04:07 -0500 Subject: [PATCH 1/3] [libc++][ci] Use upload-artifact@v4 instead of @v3 The upload-artifact@v3 action is using Node 16, which is reaching EOL. As a result, we are getting warnings prompting us to move our jobs over to the latest version of upload-artifact. --- .github/workflows/libcxx-build-and-test.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml index 9579c05f1c5b1..ba5a63eac8bf8 100644 --- a/.github/workflows/libcxx-build-and-test.yaml +++ b/.github/workflows/libcxx-build-and-test.yaml @@ -75,7 +75,7 @@ jobs: CC: ${{ matrix.cc }} CXX: ${{ matrix.cxx }} ENABLE_CLANG_TIDY: ${{ matrix.clang_tidy }} - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 if: always() with: name: ${{ matrix.config }}-${{ matrix.cxx }}-results @@ -124,7 +124,7 @@ jobs: CC: ${{ matrix.cc }} CXX: ${{ matrix.cxx }} ENABLE_CLANG_TIDY: ${{ matrix.clang_tidy }} - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 if: always() # Upload artifacts even if the build or test suite fails with: name: ${{ matrix.config }}-results @@ -189,7 +189,7 @@ jobs: CC: clang-18 CXX: clang++-18 ENABLE_CLANG_TIDY: "OFF" - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 if: always() with: name: ${{ matrix.config }}-results From 79d3cccbe2b4c4ff134b4a0e72e913deb566b8c1 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Mon, 29 Jan 2024 12:01:37 -0500 Subject: [PATCH 2/3] Hashpin the action instead --- .github/workflows/libcxx-build-and-test.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml index ba5a63eac8bf8..e35c0b2c3bed8 100644 --- a/.github/workflows/libcxx-build-and-test.yaml +++ b/.github/workflows/libcxx-build-and-test.yaml @@ -75,7 +75,7 @@ jobs: CC: ${{ matrix.cc }} CXX: ${{ matrix.cxx }} ENABLE_CLANG_TIDY: ${{ matrix.clang_tidy }} - - uses: actions/upload-artifact@v4 + - uses: actions/upload-artifact@26f96dfa697d77e81fd5907df203aa23a56210a8 # v4.3.0 if: always() with: name: ${{ matrix.config }}-${{ matrix.cxx }}-results @@ -124,7 +124,7 @@ jobs: CC: ${{ matrix.cc }} CXX: ${{ matrix.cxx }} ENABLE_CLANG_TIDY: ${{ matrix.clang_tidy }} - - uses: actions/upload-artifact@v4 + - uses: actions/upload-artifact@26f96dfa697d77e81fd5907df203aa23a56210a8 # v4.3.0 if: always() # Upload artifacts even if the build or test suite fails with: name: ${{ matrix.config }}-results @@ -189,7 +189,7 @@ jobs: CC: clang-18 CXX: clang++-18 ENABLE_CLANG_TIDY: "OFF" - - uses: actions/upload-artifact@v4 + - uses: actions/upload-artifact@26f96dfa697d77e81fd5907df203aa23a56210a8 # v4.3.0 if: always() with: name: ${{ matrix.config }}-results From 4c8ac9c01eba425911cc8db6319c29442418b2cc Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Mon, 29 Jan 2024 12:08:13 -0500 Subject: [PATCH 3/3] Make sure we have unique names for all artifacts --- .github/workflows/libcxx-build-and-test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml index e35c0b2c3bed8..4a881ef5ff56a 100644 --- a/.github/workflows/libcxx-build-and-test.yaml +++ b/.github/workflows/libcxx-build-and-test.yaml @@ -127,7 +127,7 @@ jobs: - uses: actions/upload-artifact@26f96dfa697d77e81fd5907df203aa23a56210a8 # v4.3.0 if: always() # Upload artifacts even if the build or test suite fails with: - name: ${{ matrix.config }}-results + name: ${{ matrix.config }}-${{ matrix.cxx }}-results path: | **/test-results.xml **/*.abilist