diff --git a/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp b/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp index 8c1f8dca4e102..7bdd4f8f4dbc3 100644 --- a/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp +++ b/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp @@ -3749,11 +3749,6 @@ bool RISCVDAGToDAGISel::performCombineVMergeAndVOps(SDNode *N) { // If True has a merge operand then it needs to be the same as vmerge's False, // since False will be used for the result's merge operand. if (HasTiedDest && !isImplicitDef(True->getOperand(0))) { - // The vmerge instruction must be TU. - // FIXME: This could be relaxed, but we need to handle the policy for the - // resulting op correctly. - if (isImplicitDef(Merge)) - return false; SDValue MergeOpTrue = True->getOperand(0); if (False != MergeOpTrue) return false; @@ -3763,9 +3758,6 @@ bool RISCVDAGToDAGISel::performCombineVMergeAndVOps(SDNode *N) { // going to keep the mask from True. if (IsMasked) { assert(HasTiedDest && "Expected tied dest"); - // The vmerge instruction must be TU. - if (isImplicitDef(Merge)) - return false; // FIXME: Support mask agnostic True instruction which would have an // undef merge operand. if (Mask && !usesAllOnesMask(Mask, Glue)) diff --git a/llvm/test/CodeGen/RISCV/rvv/rvv-peephole-vmerge-vops.ll b/llvm/test/CodeGen/RISCV/rvv/rvv-peephole-vmerge-vops.ll index 183741dd1ac33..b6921abf8fdf4 100644 --- a/llvm/test/CodeGen/RISCV/rvv/rvv-peephole-vmerge-vops.ll +++ b/llvm/test/CodeGen/RISCV/rvv/rvv-peephole-vmerge-vops.ll @@ -1144,3 +1144,37 @@ define @vpmerge_vfwsub.w_tied( %passt %b = call @llvm.vp.merge.nxv2f64( %mask, %a, %passthru, i32 %vl) ret %b } + +define @true_tied_dest_vmerge_implicit_passthru( %passthru, %x, %y, %m, i64 %avl) { +; CHECK-LABEL: true_tied_dest_vmerge_implicit_passthru: +; CHECK: # %bb.0: +; CHECK-NEXT: vsetvli zero, a0, e32, m1, ta, mu +; CHECK-NEXT: vmacc.vv v8, v9, v10, v0.t +; CHECK-NEXT: ret + %a = call @llvm.riscv.vmacc.nxv2i32.nxv2i32( %passthru, %x, %y, i64 %avl, i64 0) + %b = call @llvm.riscv.vmerge.nxv2i32.nxv2i32( + poison, + %passthru, + %a, + %m, + i64 %avl + ) + ret %b +} + +define @true_mask_vmerge_implicit_passthru( %passthru, %x, %y, %m, i64 %avl) { +; CHECK-LABEL: true_mask_vmerge_implicit_passthru: +; CHECK: # %bb.0: +; CHECK-NEXT: vsetvli zero, a0, e32, m1, ta, mu +; CHECK-NEXT: vadd.vv v8, v9, v10, v0.t +; CHECK-NEXT: ret + %a = call @llvm.riscv.vadd.mask.nxv2i32.nxv2i32( %passthru, %x, %y, %m, i64 %avl, i64 0) + %b = call @llvm.riscv.vmerge.nxv2i32.nxv2i32( + poison, + %passthru, + %a, + shufflevector( insertelement( poison, i1 true, i32 0), poison, zeroinitializer), + i64 %avl + ) + ret %b +} diff --git a/llvm/test/CodeGen/RISCV/rvv/vmadd-vp.ll b/llvm/test/CodeGen/RISCV/rvv/vmadd-vp.ll index 0322c1ab9f631..22ed56afbd94e 100644 --- a/llvm/test/CodeGen/RISCV/rvv/vmadd-vp.ll +++ b/llvm/test/CodeGen/RISCV/rvv/vmadd-vp.ll @@ -81,9 +81,8 @@ define @vmadd_vv_nxv1i8_ta( %a, @vmadd_vx_nxv1i8_ta( %a, i8 %b, %c, %m, i32 zeroext %evl) { ; CHECK-LABEL: vmadd_vx_nxv1i8_ta: ; CHECK: # %bb.0: -; CHECK-NEXT: vsetvli zero, a1, e8, mf8, ta, ma -; CHECK-NEXT: vmacc.vx v9, a0, v8 -; CHECK-NEXT: vmerge.vvm v8, v8, v9, v0 +; CHECK-NEXT: vsetvli zero, a1, e8, mf8, ta, mu +; CHECK-NEXT: vmadd.vx v8, a0, v9, v0.t ; CHECK-NEXT: ret %elt.head = insertelement poison, i8 %b, i32 0 %vb = shufflevector %elt.head, poison, zeroinitializer @@ -170,9 +169,8 @@ define @vmadd_vv_nxv2i8_ta( %a, @vmadd_vx_nxv2i8_ta( %a, i8 %b, %c, %m, i32 zeroext %evl) { ; CHECK-LABEL: vmadd_vx_nxv2i8_ta: ; CHECK: # %bb.0: -; CHECK-NEXT: vsetvli zero, a1, e8, mf4, ta, ma -; CHECK-NEXT: vmacc.vx v9, a0, v8 -; CHECK-NEXT: vmerge.vvm v8, v8, v9, v0 +; CHECK-NEXT: vsetvli zero, a1, e8, mf4, ta, mu +; CHECK-NEXT: vmadd.vx v8, a0, v9, v0.t ; CHECK-NEXT: ret %elt.head = insertelement poison, i8 %b, i32 0 %vb = shufflevector %elt.head, poison, zeroinitializer @@ -259,9 +257,8 @@ define @vmadd_vv_nxv4i8_ta( %a, @vmadd_vx_nxv4i8_ta( %a, i8 %b, %c, %m, i32 zeroext %evl) { ; CHECK-LABEL: vmadd_vx_nxv4i8_ta: ; CHECK: # %bb.0: -; CHECK-NEXT: vsetvli zero, a1, e8, mf2, ta, ma -; CHECK-NEXT: vmacc.vx v9, a0, v8 -; CHECK-NEXT: vmerge.vvm v8, v8, v9, v0 +; CHECK-NEXT: vsetvli zero, a1, e8, mf2, ta, mu +; CHECK-NEXT: vmadd.vx v8, a0, v9, v0.t ; CHECK-NEXT: ret %elt.head = insertelement poison, i8 %b, i32 0 %vb = shufflevector %elt.head, poison, zeroinitializer @@ -348,9 +345,8 @@ define @vmadd_vv_nxv8i8_ta( %a, @vmadd_vx_nxv8i8_ta( %a, i8 %b, %c, %m, i32 zeroext %evl) { ; CHECK-LABEL: vmadd_vx_nxv8i8_ta: ; CHECK: # %bb.0: -; CHECK-NEXT: vsetvli zero, a1, e8, m1, ta, ma -; CHECK-NEXT: vmacc.vx v9, a0, v8 -; CHECK-NEXT: vmerge.vvm v8, v8, v9, v0 +; CHECK-NEXT: vsetvli zero, a1, e8, m1, ta, mu +; CHECK-NEXT: vmadd.vx v8, a0, v9, v0.t ; CHECK-NEXT: ret %elt.head = insertelement poison, i8 %b, i32 0 %vb = shufflevector %elt.head, poison, zeroinitializer @@ -437,9 +433,8 @@ define @vmadd_vv_nxv16i8_ta( %a, @vmadd_vx_nxv16i8_ta( %a, i8 %b, %c, %m, i32 zeroext %evl) { ; CHECK-LABEL: vmadd_vx_nxv16i8_ta: ; CHECK: # %bb.0: -; CHECK-NEXT: vsetvli zero, a1, e8, m2, ta, ma -; CHECK-NEXT: vmacc.vx v10, a0, v8 -; CHECK-NEXT: vmerge.vvm v8, v8, v10, v0 +; CHECK-NEXT: vsetvli zero, a1, e8, m2, ta, mu +; CHECK-NEXT: vmadd.vx v8, a0, v10, v0.t ; CHECK-NEXT: ret %elt.head = insertelement poison, i8 %b, i32 0 %vb = shufflevector %elt.head, poison, zeroinitializer @@ -526,9 +521,8 @@ define @vmadd_vv_nxv32i8_ta( %a, @vmadd_vx_nxv32i8_ta( %a, i8 %b, %c, %m, i32 zeroext %evl) { ; CHECK-LABEL: vmadd_vx_nxv32i8_ta: ; CHECK: # %bb.0: -; CHECK-NEXT: vsetvli zero, a1, e8, m4, ta, ma -; CHECK-NEXT: vmacc.vx v12, a0, v8 -; CHECK-NEXT: vmerge.vvm v8, v8, v12, v0 +; CHECK-NEXT: vsetvli zero, a1, e8, m4, ta, mu +; CHECK-NEXT: vmadd.vx v8, a0, v12, v0.t ; CHECK-NEXT: ret %elt.head = insertelement poison, i8 %b, i32 0 %vb = shufflevector %elt.head, poison, zeroinitializer @@ -618,9 +612,8 @@ define @vmadd_vv_nxv64i8_ta( %a, @vmadd_vx_nxv64i8_ta( %a, i8 %b, %c, %m, i32 zeroext %evl) { ; CHECK-LABEL: vmadd_vx_nxv64i8_ta: ; CHECK: # %bb.0: -; CHECK-NEXT: vsetvli zero, a1, e8, m8, ta, ma -; CHECK-NEXT: vmacc.vx v16, a0, v8 -; CHECK-NEXT: vmerge.vvm v8, v8, v16, v0 +; CHECK-NEXT: vsetvli zero, a1, e8, m8, ta, mu +; CHECK-NEXT: vmadd.vx v8, a0, v16, v0.t ; CHECK-NEXT: ret %elt.head = insertelement poison, i8 %b, i32 0 %vb = shufflevector %elt.head, poison, zeroinitializer @@ -707,9 +700,8 @@ define @vmadd_vv_nxv1i16_ta( %a, @vmadd_vx_nxv1i16_ta( %a, i16 %b, %c, %m, i32 zeroext %evl) { ; CHECK-LABEL: vmadd_vx_nxv1i16_ta: ; CHECK: # %bb.0: -; CHECK-NEXT: vsetvli zero, a1, e16, mf4, ta, ma -; CHECK-NEXT: vmacc.vx v9, a0, v8 -; CHECK-NEXT: vmerge.vvm v8, v8, v9, v0 +; CHECK-NEXT: vsetvli zero, a1, e16, mf4, ta, mu +; CHECK-NEXT: vmadd.vx v8, a0, v9, v0.t ; CHECK-NEXT: ret %elt.head = insertelement poison, i16 %b, i32 0 %vb = shufflevector %elt.head, poison, zeroinitializer @@ -796,9 +788,8 @@ define @vmadd_vv_nxv2i16_ta( %a, @vmadd_vx_nxv2i16_ta( %a, i16 %b, %c, %m, i32 zeroext %evl) { ; CHECK-LABEL: vmadd_vx_nxv2i16_ta: ; CHECK: # %bb.0: -; CHECK-NEXT: vsetvli zero, a1, e16, mf2, ta, ma -; CHECK-NEXT: vmacc.vx v9, a0, v8 -; CHECK-NEXT: vmerge.vvm v8, v8, v9, v0 +; CHECK-NEXT: vsetvli zero, a1, e16, mf2, ta, mu +; CHECK-NEXT: vmadd.vx v8, a0, v9, v0.t ; CHECK-NEXT: ret %elt.head = insertelement poison, i16 %b, i32 0 %vb = shufflevector %elt.head, poison, zeroinitializer @@ -885,9 +876,8 @@ define @vmadd_vv_nxv4i16_ta( %a, @vmadd_vx_nxv4i16_ta( %a, i16 %b, %c, %m, i32 zeroext %evl) { ; CHECK-LABEL: vmadd_vx_nxv4i16_ta: ; CHECK: # %bb.0: -; CHECK-NEXT: vsetvli zero, a1, e16, m1, ta, ma -; CHECK-NEXT: vmacc.vx v9, a0, v8 -; CHECK-NEXT: vmerge.vvm v8, v8, v9, v0 +; CHECK-NEXT: vsetvli zero, a1, e16, m1, ta, mu +; CHECK-NEXT: vmadd.vx v8, a0, v9, v0.t ; CHECK-NEXT: ret %elt.head = insertelement poison, i16 %b, i32 0 %vb = shufflevector %elt.head, poison, zeroinitializer @@ -974,9 +964,8 @@ define @vmadd_vv_nxv8i16_ta( %a, @vmadd_vx_nxv8i16_ta( %a, i16 %b, %c, %m, i32 zeroext %evl) { ; CHECK-LABEL: vmadd_vx_nxv8i16_ta: ; CHECK: # %bb.0: -; CHECK-NEXT: vsetvli zero, a1, e16, m2, ta, ma -; CHECK-NEXT: vmacc.vx v10, a0, v8 -; CHECK-NEXT: vmerge.vvm v8, v8, v10, v0 +; CHECK-NEXT: vsetvli zero, a1, e16, m2, ta, mu +; CHECK-NEXT: vmadd.vx v8, a0, v10, v0.t ; CHECK-NEXT: ret %elt.head = insertelement poison, i16 %b, i32 0 %vb = shufflevector %elt.head, poison, zeroinitializer @@ -1063,9 +1052,8 @@ define @vmadd_vv_nxv16i16_ta( %a, @vmadd_vx_nxv16i16_ta( %a, i16 %b, %c, %m, i32 zeroext %evl) { ; CHECK-LABEL: vmadd_vx_nxv16i16_ta: ; CHECK: # %bb.0: -; CHECK-NEXT: vsetvli zero, a1, e16, m4, ta, ma -; CHECK-NEXT: vmacc.vx v12, a0, v8 -; CHECK-NEXT: vmerge.vvm v8, v8, v12, v0 +; CHECK-NEXT: vsetvli zero, a1, e16, m4, ta, mu +; CHECK-NEXT: vmadd.vx v8, a0, v12, v0.t ; CHECK-NEXT: ret %elt.head = insertelement poison, i16 %b, i32 0 %vb = shufflevector %elt.head, poison, zeroinitializer @@ -1155,9 +1143,8 @@ define @vmadd_vv_nxv32i16_ta( %a, @vmadd_vx_nxv32i16_ta( %a, i16 %b, %c, %m, i32 zeroext %evl) { ; CHECK-LABEL: vmadd_vx_nxv32i16_ta: ; CHECK: # %bb.0: -; CHECK-NEXT: vsetvli zero, a1, e16, m8, ta, ma -; CHECK-NEXT: vmacc.vx v16, a0, v8 -; CHECK-NEXT: vmerge.vvm v8, v8, v16, v0 +; CHECK-NEXT: vsetvli zero, a1, e16, m8, ta, mu +; CHECK-NEXT: vmadd.vx v8, a0, v16, v0.t ; CHECK-NEXT: ret %elt.head = insertelement poison, i16 %b, i32 0 %vb = shufflevector %elt.head, poison, zeroinitializer @@ -1244,9 +1231,8 @@ define @vmadd_vv_nxv1i32_ta( %a, @vmadd_vx_nxv1i32_ta( %a, i32 %b, %c, %m, i32 zeroext %evl) { ; CHECK-LABEL: vmadd_vx_nxv1i32_ta: ; CHECK: # %bb.0: -; CHECK-NEXT: vsetvli zero, a1, e32, mf2, ta, ma -; CHECK-NEXT: vmacc.vx v9, a0, v8 -; CHECK-NEXT: vmerge.vvm v8, v8, v9, v0 +; CHECK-NEXT: vsetvli zero, a1, e32, mf2, ta, mu +; CHECK-NEXT: vmadd.vx v8, a0, v9, v0.t ; CHECK-NEXT: ret %elt.head = insertelement poison, i32 %b, i32 0 %vb = shufflevector %elt.head, poison, zeroinitializer @@ -1333,9 +1319,8 @@ define @vmadd_vv_nxv2i32_ta( %a, @vmadd_vx_nxv2i32_ta( %a, i32 %b, %c, %m, i32 zeroext %evl) { ; CHECK-LABEL: vmadd_vx_nxv2i32_ta: ; CHECK: # %bb.0: -; CHECK-NEXT: vsetvli zero, a1, e32, m1, ta, ma -; CHECK-NEXT: vmacc.vx v9, a0, v8 -; CHECK-NEXT: vmerge.vvm v8, v8, v9, v0 +; CHECK-NEXT: vsetvli zero, a1, e32, m1, ta, mu +; CHECK-NEXT: vmadd.vx v8, a0, v9, v0.t ; CHECK-NEXT: ret %elt.head = insertelement poison, i32 %b, i32 0 %vb = shufflevector %elt.head, poison, zeroinitializer @@ -1422,9 +1407,8 @@ define @vmadd_vv_nxv4i32_ta( %a, @vmadd_vx_nxv4i32_ta( %a, i32 %b, %c, %m, i32 zeroext %evl) { ; CHECK-LABEL: vmadd_vx_nxv4i32_ta: ; CHECK: # %bb.0: -; CHECK-NEXT: vsetvli zero, a1, e32, m2, ta, ma -; CHECK-NEXT: vmacc.vx v10, a0, v8 -; CHECK-NEXT: vmerge.vvm v8, v8, v10, v0 +; CHECK-NEXT: vsetvli zero, a1, e32, m2, ta, mu +; CHECK-NEXT: vmadd.vx v8, a0, v10, v0.t ; CHECK-NEXT: ret %elt.head = insertelement poison, i32 %b, i32 0 %vb = shufflevector %elt.head, poison, zeroinitializer @@ -1511,9 +1495,8 @@ define @vmadd_vv_nxv8i32_ta( %a, @vmadd_vx_nxv8i32_ta( %a, i32 %b, %c, %m, i32 zeroext %evl) { ; CHECK-LABEL: vmadd_vx_nxv8i32_ta: ; CHECK: # %bb.0: -; CHECK-NEXT: vsetvli zero, a1, e32, m4, ta, ma -; CHECK-NEXT: vmacc.vx v12, a0, v8 -; CHECK-NEXT: vmerge.vvm v8, v8, v12, v0 +; CHECK-NEXT: vsetvli zero, a1, e32, m4, ta, mu +; CHECK-NEXT: vmadd.vx v8, a0, v12, v0.t ; CHECK-NEXT: ret %elt.head = insertelement poison, i32 %b, i32 0 %vb = shufflevector %elt.head, poison, zeroinitializer @@ -1603,9 +1586,8 @@ define @vmadd_vv_nxv16i32_ta( %a, @vmadd_vx_nxv16i32_ta( %a, i32 %b, %c, %m, i32 zeroext %evl) { ; CHECK-LABEL: vmadd_vx_nxv16i32_ta: ; CHECK: # %bb.0: -; CHECK-NEXT: vsetvli zero, a1, e32, m8, ta, ma -; CHECK-NEXT: vmacc.vx v16, a0, v8 -; CHECK-NEXT: vmerge.vvm v8, v8, v16, v0 +; CHECK-NEXT: vsetvli zero, a1, e32, m8, ta, mu +; CHECK-NEXT: vmadd.vx v8, a0, v16, v0.t ; CHECK-NEXT: ret %elt.head = insertelement poison, i32 %b, i32 0 %vb = shufflevector %elt.head, poison, zeroinitializer @@ -1739,9 +1721,8 @@ define @vmadd_vx_nxv1i64_ta( %a, i64 %b, poison, i64 %b, i32 0 %vb = shufflevector %elt.head, poison, zeroinitializer @@ -1875,9 +1856,8 @@ define @vmadd_vx_nxv2i64_ta( %a, i64 %b, poison, i64 %b, i32 0 %vb = shufflevector %elt.head, poison, zeroinitializer @@ -2011,9 +1991,8 @@ define @vmadd_vx_nxv4i64_ta( %a, i64 %b, poison, i64 %b, i32 0 %vb = shufflevector %elt.head, poison, zeroinitializer @@ -2150,9 +2129,8 @@ define @vmadd_vx_nxv8i64_ta( %a, i64 %b, poison, i64 %b, i32 0 %vb = shufflevector %elt.head, poison, zeroinitializer