From 3db1cc129de264cb3a47a2e81adbe70136fcbe67 Mon Sep 17 00:00:00 2001 From: Haowei Wu Date: Thu, 7 Sep 2023 14:36:12 -0700 Subject: [PATCH 1/2] [unittests] Add missing includes There are missing include and using in TextStubTests and AsmPrinterDwarfTest and they causes build failures when using vanilla GoogleTest v1.14.0. This patch fixes this issue. --- llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp | 1 + llvm/unittests/TextAPI/TextStubHelpers.h | 1 + 2 files changed, 2 insertions(+) diff --git a/llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp b/llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp index b900e34fdd634..b27ff403fb1c6 100644 --- a/llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp +++ b/llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp @@ -22,6 +22,7 @@ using namespace llvm; using testing::_; using testing::InSequence; using testing::SaveArg; +using testing::DoAll; namespace { diff --git a/llvm/unittests/TextAPI/TextStubHelpers.h b/llvm/unittests/TextAPI/TextStubHelpers.h index f3303da3b951b..f8409b10912c3 100644 --- a/llvm/unittests/TextAPI/TextStubHelpers.h +++ b/llvm/unittests/TextAPI/TextStubHelpers.h @@ -6,6 +6,7 @@ // //===-----------------------------------------------------------------------===/ +#include "llvm/ADT/SmallString.h" #include "llvm/Support/MemoryBuffer.h" #include "llvm/TextAPI/InterfaceFile.h" #include From f15ab23dba5e0524cf54d184e7e9dbe0fd31e79b Mon Sep 17 00:00:00 2001 From: Haowei Wu Date: Thu, 7 Sep 2023 15:29:27 -0700 Subject: [PATCH 2/2] amend! [unittests] Add missing includes [unittests] Add missing includes There are missing include and using in TextStubTests and AsmPrinterDwarfTest and they causes build failures when using vanilla GoogleTest v1.14.0. This patch fixes this issue. --- llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp b/llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp index b27ff403fb1c6..32319f1e97587 100644 --- a/llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp +++ b/llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp @@ -20,9 +20,9 @@ using namespace llvm; using testing::_; +using testing::DoAll; using testing::InSequence; using testing::SaveArg; -using testing::DoAll; namespace {