[CodeGen][test][NFC] Refactor ObjC attribute tests #156519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiraditya
approved these changes
Sep 3, 2025
Collaborator
hiraditya
left a comment
hiraditya
left a comment
There was a problem hiding this comment.
I'm not actively working on it but LGTM as it is NFC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some downstream work broke these tests because the attribute number changed. Refactor these tests to be more resilient in the face of changes like this
instrument-objc-method.m#1was never checked, I think it was trying to check that__cyg_profile_func_enterwas not used, so I added--implicit-check-not="__cyg_profile_func_enter"[[#ATTR:]]so the test doesn't fail if the number changesaddress-safety-attr.mmFunction Attrs:so it's independent of the attribute number