[clang-fuzzer] Fix latent race condition in build #146119
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add explicit dependency for gen_vt to the CMakeLists.txt for clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp to prevent race condition on generation of llvm/CodeGen/GenVT.inc This explicit dependency was added in other CMakeLists.txt when the tablegen was added for GenVT.inc file in https://reviews.llvm.org/D148770, but not for handle-llvm A similar fix was made in llvm#109306
|
@llvm/pr-subscribers-clang Author: Paddy McDonald (padriff) ChangesAdd explicit dependency for gen_vt to the CMakeLists.txt for clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp to prevent race condition on generation of llvm/CodeGen/GenVT.inc This explicit dependency was added in other CMakeLists.txt when the tablegen was added for GenVT.inc file in https://reviews.llvm.org/D148770, but not for handle-llvm A similar fix was made in #109306 Full diff: https://github.com/llvm/llvm-project/pull/146119.diff 1 Files Affected:
diff --git a/clang/tools/clang-fuzzer/handle-llvm/CMakeLists.txt b/clang/tools/clang-fuzzer/handle-llvm/CMakeLists.txt
index 9962f9850f545..49a95a02d0447 100644
--- a/clang/tools/clang-fuzzer/handle-llvm/CMakeLists.txt
+++ b/clang/tools/clang-fuzzer/handle-llvm/CMakeLists.txt
@@ -24,4 +24,5 @@ add_clang_library(clangHandleLLVM
DEPENDS
intrinsics_gen
+ vt_gen
)
|
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/12728 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit dependency for gen_vt to the CMakeLists.txt for clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp to prevent race condition on generation of llvm/CodeGen/GenVT.inc This explicit dependency was added in other CMakeLists.txt when the tablegen was added for GenVT.inc file in https://reviews.llvm.org/D148770, but not for handle-llvm
A similar fix was made in #109306
rdar://151325382