From 943bd9557507efdb84e31a67b78d63f78a7f7b8e Mon Sep 17 00:00:00 2001 From: Matthias Springer Date: Mon, 11 Nov 2024 03:32:55 +0100 Subject: [PATCH] [mlir][IR][NFC] `PostDominanceInfo`: Mark all functions as `const` Same as `DominanceInfo`, all functions should be `const`. --- mlir/include/mlir/IR/Dominance.h | 8 ++++---- mlir/lib/IR/Dominance.cpp | 3 ++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/mlir/include/mlir/IR/Dominance.h b/mlir/include/mlir/IR/Dominance.h index 95c99bd59f7b2..66b9456533ae0 100644 --- a/mlir/include/mlir/IR/Dominance.h +++ b/mlir/include/mlir/IR/Dominance.h @@ -202,20 +202,20 @@ class PostDominanceInfo : public detail::DominanceInfoBase { using super::super; /// Return true if operation A properly postdominates operation B. - bool properlyPostDominates(Operation *a, Operation *b); + bool properlyPostDominates(Operation *a, Operation *b) const; /// Return true if operation A postdominates operation B. - bool postDominates(Operation *a, Operation *b) { + bool postDominates(Operation *a, Operation *b) const { return a == b || properlyPostDominates(a, b); } /// Return true if the specified block A properly postdominates block B. - bool properlyPostDominates(Block *a, Block *b) { + bool properlyPostDominates(Block *a, Block *b) const { return super::properlyDominates(a, b); } /// Return true if the specified block A postdominates block B. - bool postDominates(Block *a, Block *b) { + bool postDominates(Block *a, Block *b) const { return a == b || properlyPostDominates(a, b); } }; diff --git a/mlir/lib/IR/Dominance.cpp b/mlir/lib/IR/Dominance.cpp index 31f7e7dbc925c..62477a823acaa 100644 --- a/mlir/lib/IR/Dominance.cpp +++ b/mlir/lib/IR/Dominance.cpp @@ -327,7 +327,8 @@ bool DominanceInfo::properlyDominates(Value a, Operation *b) const { //===----------------------------------------------------------------------===// /// Returns true if statement 'a' properly postdominates statement b. -bool PostDominanceInfo::properlyPostDominates(Operation *a, Operation *b) { +bool PostDominanceInfo::properlyPostDominates(Operation *a, + Operation *b) const { auto *aBlock = a->getBlock(), *bBlock = b->getBlock(); assert(aBlock && bBlock && "operations must be in a block");