diff --git a/clang/lib/AST/ByteCode/Compiler.cpp b/clang/lib/AST/ByteCode/Compiler.cpp index 265350e44d95b..fe9da7801185e 100644 --- a/clang/lib/AST/ByteCode/Compiler.cpp +++ b/clang/lib/AST/ByteCode/Compiler.cpp @@ -2613,18 +2613,46 @@ bool Compiler::VisitCXXReinterpretCastExpr( const CXXReinterpretCastExpr *E) { const Expr *SubExpr = E->getSubExpr(); - bool Fatal = false; std::optional FromT = classify(SubExpr); std::optional ToT = classify(E); + if (!FromT || !ToT) - Fatal = true; - else - Fatal = (ToT != FromT); + return this->emitInvalidCast(CastKind::Reinterpret, /*Fatal=*/true, E); + + if (FromT == PT_Ptr || ToT == PT_Ptr) { + // Both types could be PT_Ptr because their expressions are glvalues. + std::optional PointeeFromT; + if (SubExpr->getType()->isPointerOrReferenceType()) + PointeeFromT = classify(SubExpr->getType()->getPointeeType()); + else + PointeeFromT = classify(SubExpr->getType()); + + std::optional PointeeToT; + if (E->getType()->isPointerOrReferenceType()) + PointeeToT = classify(E->getType()->getPointeeType()); + else + PointeeToT = classify(E->getType()); + + bool Fatal = true; + if (PointeeToT && PointeeFromT) { + if (isIntegralType(*PointeeFromT) && isIntegralType(*PointeeToT)) + Fatal = false; + } + + if (!this->emitInvalidCast(CastKind::Reinterpret, Fatal, E)) + return false; + + if (E->getCastKind() == CK_LValueBitCast) + return this->delegate(SubExpr); + return this->VisitCastExpr(E); + } + // Try to actually do the cast. + bool Fatal = (ToT != FromT); if (!this->emitInvalidCast(CastKind::Reinterpret, Fatal, E)) return false; - return this->delegate(SubExpr); + return this->VisitCastExpr(E); } template diff --git a/clang/test/AST/ByteCode/invalid.cpp b/clang/test/AST/ByteCode/invalid.cpp index 13ba84bcad104..2a6c2d13e8467 100644 --- a/clang/test/AST/ByteCode/invalid.cpp +++ b/clang/test/AST/ByteCode/invalid.cpp @@ -54,4 +54,7 @@ namespace Casts { B b; (void)*reinterpret_cast(&b); // both-error {{indirection not permitted on operand of type 'void *'}} } + + /// Just make sure this doesn't crash. + float PR9558 = reinterpret_cast("asd"); }