Merge r344454, r344455 and r344645 into the 7.0 branch

[llvmbot]

Bugzilla Link	39507
Resolution	FIXED
Resolved on	Nov 01, 2018 19:26
Version	7.0
OS	Linux
Blocks	#38454
Reporter	LLVM Bugzilla Contributor
CC	@tstellar
Fixed by commit(s)	r344454 r344455 r344645 r345921

Extended Description

These commits fix a crash (reported in #38525 ) that was introduced in version 3.9 and poses a major issue in KLEE.

Can the following patches be merged into release_70? Or would these changes need to be backported without modifications in any function signatures?

https://reviews.llvm.org/rL344454
https://reviews.llvm.org/rL344455
https://reviews.llvm.org/rL344645

[llvmbot]

assigned to @efriedma-quic

[tstellar]

It looks like the first patch changes the function signature, but then the third patch changes it back, so that would be OK, if these are all merged together.

Eli, what do you think about merging these patches?

[efriedma-quic]

Yes, if you look at the patches together, there aren't actually any API changes, just one new API.

There have't been any regressions reported on trunk, and it seems low risk. LGTM.

[tstellar]

Merged: r345921