Skip to content

Integrate r340025 into 7.0.1 #38731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
llvmbot opened this issue Oct 22, 2018 · 4 comments
Closed

Integrate r340025 into 7.0.1 #38731

llvmbot opened this issue Oct 22, 2018 · 4 comments
Assignees
Labels
bugzilla Issues migrated from bugzilla clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl'

Comments

@llvmbot
Copy link
Member

llvmbot commented Oct 22, 2018

Bugzilla Link 39383
Resolution FIXED
Resolved on Oct 25, 2018 13:41
Version 7.0
OS Windows NT
Blocks #38454
Reporter LLVM Bugzilla Contributor
CC @tstellar
Fixed by commit(s) r340025 r345311

Extended Description

Please integrate the following change into 7.0.1 branch. This was a regression from Clang 6. Thank you!

commit 507f9cad077310d66051b8d79284e72115579be8 (HEAD -> release_70)
Author: Erich Keane [email protected]
Date: Fri Aug 17 13:43:39 2018 +0000

Fix for bug 38508 - Don't do PCH processing when only generating preprocessor output

This clang-cl driver change removes the PCH options when we are only generating
preprocessed output. This is similar to the behavior of Y-.

Patch by: mikerice
Differential Revision: https://reviews.llvm.org/D50640


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@340025 91177308-0d34-0410-b5e6-96231b3b80d8
@llvmbot
Copy link
Member Author

llvmbot commented Oct 22, 2018

assigned to @tstellar

@tstellar
Copy link
Collaborator

Hi Richard,

Is this OK to merge to the release_70 branch?

https://reviews.llvm.org/rL340025

@zygoloid
Copy link
Mannequin

zygoloid mannequin commented Oct 23, 2018

Looks good to merge.

@tstellar
Copy link
Collaborator

Merged: r345311

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl'
Projects
None yet
Development

No branches or pull requests

2 participants