Skip to content

Do you still need commit access? #140431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tstellar opened this issue May 18, 2025 · 14 comments
Open

Do you still need commit access? #140431

tstellar opened this issue May 18, 2025 · 14 comments

Comments

@tstellar
Copy link
Collaborator

TLDR: If you want to retain your commit access, please comment on this issue. Otherwise, you can unsubscribe from this issue and ignore it. Commit access is not required to contribute to the project. You can still create Pull Requests without commit access.

@Teemperor @mgehre @jbcoe @faisalv @xiangzhai @harlanhaskins @kaomoneus @nandor @k15tfu @isanbard @asaadaldien @davezarzycki @vlad902 @ddcc @kubamracek @Kariddi @arnamoy10 @jankratochvil @Keno @ColdenCullen @rdwampler @jberdine @mhjacobson @wanders @stephanemoore

LLVM has a policy of downgrading write access to its repositories for accounts with long term inactivity. This is done because inactive accounts with high levels of access tend to be at increased risk of compromise and this is one tactic that the project employs to guard itself from malicious actors. Note that write access is not required to contribute to the project. You can still submit pull requests and have someone else merge them.

Our project policy is to ping anyone with less than five 'interactions' with the repositories over a 12 month period to see if they still need commit access. An 'interaction' and be any one of:

  • Pushing a commit.
  • Merging a pull request (either their own or someone else’s).
  • Commenting on a PR.

If you want to retain your commit access, please post a comment on this issue. If you do not want to keep your commit access, you can just ignore this issue. If you have not responded in 4 weeks, then you will move moved from the 'write' role within the project to the 'triage' role. The 'triage' role is still a privileged role and will allow you to do the following:

  • Review Pull Requests.
  • Comment on issues.
  • Apply/dismiss labels.
  • Close, reopen, and assign all issues and pull requests.
  • Apply milestones.
  • Mark duplicate issues and pull requests.
  • Request pull request reviews.
  • Hide anyone’s comments.
@ddcc
Copy link
Member

ddcc commented May 18, 2025

Yes, I'd like to keep my access.

@harlanhaskins
Copy link
Collaborator

I’d also like to keep my access

@stephanemoore
Copy link
Contributor

I would like to keep my access.

@jbcoe
Copy link
Contributor

jbcoe commented May 18, 2025

I’d like to keep my commit access.

@jberdine
Copy link
Contributor

Yes, I would like to keep my commit access.

@davezarzycki
Copy link
Member

Hi @tstellar – I think inactive contributors (or at least myself) would be more comfortable with giving up commit access if the procedure for regaining access were spelled out in the the above rational for downgrading access. For example, saying "you just get put on an 'inactive' list in the project and if you make a few contributions in a year then we'll happily restore your commit access". Honestly, if the policy were well balanced, then you could just automatically downgrade people instead of pinging them like this.

TL;DR – I'll assume that regaining access won't be hard so sure, downgrade my access.

@Teemperor
Copy link
Collaborator

I think the script (?) that makes the list for this bug (or the removal script) is broken. I was already mentioned in the last issue about this and somehow I'm still in this issue :').

Also yes, please remove me from the committer list as I don't use it right now.

@faisalv
Copy link
Contributor

faisalv commented May 18, 2025

I too would like to hold on to my commit access for now - i'm hoping to hellp with work on reflection once dan starts merging his work into trunk.
Thanks for checking!

@quic-garvgupt
Copy link
Contributor

I'd like to keep my commit access

@isanbard
Copy link
Contributor

Please keep @isanbard around. It's my non-work account.

@Keno
Copy link
Member

Keno commented May 19, 2025

Retain my access, please

@kubamracek
Copy link
Member

I would like to keep my access.

@tstellar
Copy link
Collaborator Author

I think the script (?) that makes the list for this bug (or the removal script) is broken. I was already mentioned in the last issue about this and somehow I'm still in this issue :').

Also yes, please remove me from the committer list as I don't use it right now.

The script is correct, because you still have commit access, maybe there was a mistake in removing your commit access last time?

@tstellar
Copy link
Collaborator Author

Hi @tstellar – I think inactive contributors (or at least myself) would be more comfortable with giving up commit access if the procedure for regaining access were spelled out in the the above rational for downgrading access. For example, saying "you just get put on an 'inactive' list in the project and if you make a few contributions in a year then we'll happily restore your commit access". Honestly, if the policy were well balanced, then you could just automatically downgrade people instead of pinging them like this.

TL;DR – I'll assume that regaining access won't be hard so sure, downgrade my access.

Thanks for the feedback. I will update the message to include instructions for how to re-apply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests