-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[libc] clean up use of __builtin_popcountl in sched_getcpucount #128781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi! This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:
If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below. |
@llvm/issue-subscribers-libc Author: Michael Jones (michaelrj-google)
In [`libc/src/sched/linux/sched_getcpucount.cpp`](https://github.com/llvm/llvm-project/blob/main/libc/src/sched/linux/sched_getcpucount.cpp) we currently use `__builtin_popcountl`. Ideally we'd instead use `cpp::popcount` defined in [`libc/src/__support/CPP/bit.h`](https://github.com/llvm/llvm-project/blob/main/libc/src/__support/CPP/bit.h#L268).
|
@llvm/issue-subscribers-good-first-issue Author: Michael Jones (michaelrj-google)
In [`libc/src/sched/linux/sched_getcpucount.cpp`](https://github.com/llvm/llvm-project/blob/main/libc/src/sched/linux/sched_getcpucount.cpp) we currently use `__builtin_popcountl`. Ideally we'd instead use `cpp::popcount` defined in [`libc/src/__support/CPP/bit.h`](https://github.com/llvm/llvm-project/blob/main/libc/src/__support/CPP/bit.h#L268).
|
i can work on this but i havent worked on an issue before it should be pretty straightforward right? |
Yes, it should be fairly straightforward. Would you like me to assign the issue to you? |
ok cool. yeah that would be great! |
@liamsemeria Are you still working on this? |
@el-ev i was struggling to build libc on arm and i've had a couple things come up. feel free to work on it too |
@el-ev I'll reassign to you for now. |
In
libc/src/sched/linux/sched_getcpucount.cpp
we currently use__builtin_popcountl
. Ideally we'd instead usecpp::popcount
defined inlibc/src/__support/CPP/bit.h
.The text was updated successfully, but these errors were encountered: