Skip to content

Deducing this feature missing feature test macro #113174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
camio opened this issue Oct 21, 2024 · 3 comments
Closed

Deducing this feature missing feature test macro #113174

camio opened this issue Oct 21, 2024 · 3 comments
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" duplicate Resolved as duplicate

Comments

@camio
Copy link
Contributor

camio commented Oct 21, 2024

According to #59619, there is no work remaining to add this feature, yet it still lacks a feature test macro which is being worked around like this in libcxx.

The release notes for clang 18.1 had this to say:

Because the support for this feature is still experimental, the feature test macro __cpp_explicit_this_parameter was not set in this version. However, its support can be tested with __has_extension(cxx_explicit_this_parameter).

If this feature is complete, the feature test macro should be added. If it is incomplete, there should be an issue to point to describing the remaining work.

@camio
Copy link
Contributor Author

camio commented Oct 21, 2024

+cc @cor3ntin

@cor3ntin
Copy link
Contributor

there are actually a couple of bugs blocking the setting of the feature test macro.
see #107451

We aim to set it in clang 20.

@frederick-vs-ja frederick-vs-ja added duplicate Resolved as duplicate clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Jan 20, 2025
@llvmbot
Copy link
Member

llvmbot commented Jan 20, 2025

@llvm/issue-subscribers-clang-frontend

Author: David Sankel (camio)

According to https://github.com//issues/59619, there is no work remaining to add this feature, yet it still lacks a feature test macro which is being worked around like [this](https://github.com/llvm/llvm-project/blob/a2ba438f3e5635e368333213914c7452a6a6a2da/libcxx/include/__config#L1228) in libcxx.

The release notes for clang 18.1 had this to say:

> Because the support for this feature is still experimental, the feature test macro __cpp_explicit_this_parameter was not set in this version. However, its support can be tested with __has_extension(cxx_explicit_this_parameter).

If this feature is complete, the feature test macro should be added. If it is incomplete, there should be an issue to point to describing the remaining work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" duplicate Resolved as duplicate
Projects
None yet
Development

No branches or pull requests

4 participants