Skip to content

GlobalIsel combiner with GIVariadic #102719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tschuett opened this issue Aug 10, 2024 · 2 comments
Closed

GlobalIsel combiner with GIVariadic #102719

tschuett opened this issue Aug 10, 2024 · 2 comments
Assignees

Comments

@tschuett
Copy link

#100563 motivated me that I wrote my first combine using GIVariadic.

See https://github.com/llvm/llvm-project/compare/main...tschuett:llvm-project:gisel-push-through-build-vector2?expand=1

The traditional buildvector_of_zext3 hits the exit in the match function. The modern buildvector_of_zext2 fails to hit the exit. I have feeling that the pattern does not match.

@tschuett
Copy link
Author

The tests for the combiner infrastructure are CHECK-lines on td files.

Better testing could be a test combiner with cpp, td, and mir files.

@Pierre-vh
Copy link
Contributor

I directly committed the fix because it was trivial.
I also agree it'd be nice to have a combiner test that actually runs, but it's difficult to setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants