Skip to content

Commit f20aa88

Browse files
committed
formatting
1 parent 52ad728 commit f20aa88

File tree

2 files changed

+16
-15
lines changed

2 files changed

+16
-15
lines changed

mlir/include/mlir/Dialect/GPU/IR/GPUOps.td

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -839,7 +839,8 @@ def GPU_LaunchOp : GPU_Op<"launch", [
839839
- a variadic number of Workgroup memory attributions.
840840
- a variadic number of Private memory attributions.
841841

842-
The `kernelFunc` and `kernelModule` attributes are optional and specifies the kernel name and a module in whichthe kernel should be outlined.
842+
The `kernelFunc` and `kernelModule` attributes are optional and specifies
843+
the kernel name and a module in whichthe kernel should be outlined.
843844

844845

845846
Syntax:

mlir/lib/Dialect/GPU/Transforms/KernelOutlining.cpp

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -366,13 +366,14 @@ class GpuKernelOutliningPass
366366
SetVector<Value> operands;
367367
std::string kernelFnName;
368368
if (op.hasKernelFuncName()) {
369-
kernelFnName = op->getAttrOfType<mlir::SymbolRefAttr>("kernelFunc").getRootReference().str();
370-
llvm::errs() << "use provided kernel func name = " << kernelFnName << "\n";
369+
kernelFnName = op->getAttrOfType<mlir::SymbolRefAttr>("kernelFunc")
370+
.getRootReference()
371+
.str();
371372
} else {
372373
kernelFnName =
373-
Twine(op->getParentOfType<SymbolOpInterface>().getName(), "_kernel")
374+
Twine(op->getParentOfType<SymbolOpInterface>().getName(),
375+
"_kernel")
374376
.str();
375-
llvm::errs() << "use default kernel func name = " << kernelFnName << "\n";
376377
}
377378

378379
gpu::GPUFuncOp outlinedFunc =
@@ -402,7 +403,8 @@ class GpuKernelOutliningPass
402403

403404
private:
404405
/// Returns a gpu.module containing kernelFunc and all callees (recursive).
405-
gpu::GPUModuleOp createKernelModule(gpu::LaunchOp gpuLaunchOp, gpu::GPUFuncOp kernelFunc,
406+
gpu::GPUModuleOp createKernelModule(gpu::LaunchOp gpuLaunchOp,
407+
gpu::GPUFuncOp kernelFunc,
406408
const SymbolTable &parentSymbolTable) {
407409
// TODO: This code cannot use an OpBuilder because it must be inserted into
408410
// a SymbolTable by the caller. SymbolTable needs to be refactored to
@@ -412,23 +414,23 @@ class GpuKernelOutliningPass
412414
OpBuilder builder(context);
413415
std::string kernelModuleName;
414416
if (gpuLaunchOp.hasKernelModuleName()) {
415-
kernelModuleName = gpuLaunchOp->getAttrOfType<mlir::SymbolRefAttr>("kernelModule").getRootReference().str();
416-
llvm::errs() << "use provided kernel module name = " << kernelModuleName << "\n";
417+
kernelModuleName =
418+
gpuLaunchOp->getAttrOfType<mlir::SymbolRefAttr>("kernelModule")
419+
.getRootReference()
420+
.str();
417421
} else {
418422
kernelModuleName = kernelFunc.getName();
419-
llvm::errs() << "use default kernel module name = " << kernelModuleName << "\n";
420423
}
421424

422425
gpu::GPUModuleOp kernelModule;
423426
// Check if the module already exists in the symbol table
424-
if (auto existingModule = parentSymbolTable.lookup<gpu::GPUModuleOp>(kernelModuleName)) {
425-
llvm::errs() << "Reusing existing kernel module: " << kernelModuleName << "\n";
427+
if (auto existingModule =
428+
parentSymbolTable.lookup<gpu::GPUModuleOp>(kernelModuleName)) {
426429
kernelModule = existingModule;
427430
} else {
428431
// If not found, create a new GPU module
429-
llvm::errs() << "Creating new kernel module: " << kernelModuleName << "\n";
430432
kernelModule = builder.create<gpu::GPUModuleOp>(kernelFunc.getLoc(),
431-
kernelModuleName);
433+
kernelModuleName);
432434
}
433435

434436
// If a valid data layout spec was provided, attach it to the kernel module.
@@ -457,8 +459,6 @@ class GpuKernelOutliningPass
457459
}
458460
}
459461

460-
//llvm::errs() << "kernelModule:\n" << kernelModule << "\n";
461-
462462
return kernelModule;
463463
}
464464

0 commit comments

Comments
 (0)