Skip to content

Commit eee8718

Browse files
committed
[lldb][test] TestDataFormatterLibcxxOptionalSimulator.py: skip on Clang-17
A Clang change introduced in this version breaks this test. Said change was reverted in `52a9ba7ca4fb9427706c28bb3ca15f7a56eecf3f` in newer versions of Clang.
1 parent 4aaa925 commit eee8718

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx-simulators/optional/TestDataFormatterLibcxxOptionalSimulator.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,12 @@ def _run_test(self, defines):
4747
name = f"test_r{r}"
4848
defines = [f"REVISION={r}"]
4949

50+
# LLDB's FormatterCache caches on DW_AT_name. A change introduced in
51+
# clang-17 (commit bee886052) changed the contents of DW_AT_name for
52+
# template specializations, which broke FormatterCache assumptions
53+
# causing this test to fail. This was reverted in newer version of clang
54+
# with commit 52a9ba7ca.
55+
@skipIf(compiler="clang", compiler_version=["=", "17"])
5056
@functools.wraps(LibcxxOptionalDataFormatterSimulatorTestCase._run_test)
5157
def test_method(self, defines=defines):
5258
LibcxxOptionalDataFormatterSimulatorTestCase._run_test(self, defines)

0 commit comments

Comments
 (0)