Skip to content

Commit ecd65e6

Browse files
authored
[DXIL][test] Fix a few tests now that HLSL functions are internalized (#106437)
These tests have been failing since db279c7 "[HLSL] Change default linkage of HLSL functions to internal (#95331)". This presumably went unnoticed because they're not run by default since they rely on an external tool (dxil-dis).
1 parent 2dc3b50 commit ecd65e6

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

llvm/test/tools/dxil-dis/BasicIR.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
; RUN: llc --filetype=obj %s --stop-after=dxil-write-bitcode -o %t && llvm-bcanalyzer --dump-blockinfo %t | FileCheck %s --check-prefix=BLOCK_INFO
44

5-
; CHECK: define i32 @foo(i32 %X, i32 %Y) {
5+
; CHECK: define internal i32 @foo(i32 %X, i32 %Y) {
66
; CHECK: %Z = sub i32 %X, %Y
77
; CHECK: %Q = add i32 %Z, %Y
88
; CHECK: ret i32 %Q

llvm/test/tools/dxil-dis/debug-info.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
target triple = "dxil-unknown-shadermodel6.7-library"
33
target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
44

5-
; CHECK: define float @fma(float, float, float) unnamed_addr #0 !dbg [[Fn:[!][0-9]+]]
5+
; CHECK: define internal float @fma(float, float, float) unnamed_addr #0 !dbg [[Fn:[!][0-9]+]]
66
; Function Attrs: norecurse nounwind readnone willreturn
77
define dso_local float @fma(float %0, float %1, float %2) local_unnamed_addr #0 !dbg !6 {
88
; CHECK-NEXT: call void @llvm.dbg.value(metadata float %0, metadata [[VarX:[!][0-9]+]], metadata [[Expr:[!][0-9]+]]), !dbg [[Line1:[!][0-9]+]]

llvm/test/tools/dxil-dis/opaque-gep.ll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ define i32 @fn(ptr %0) {
77
ret i32 %3
88
}
99

10-
; CHECK: define i32 @fn(i32*)
10+
; CHECK: define internal i32 @fn(i32*)
1111
; CHECK-NEXT: %2 = getelementptr i32, i32* %0, i32 4
1212
; CHECK-NEXT: %3 = load i32, i32* %2, align 4
1313

@@ -17,6 +17,6 @@ define i32 @fn2(ptr addrspace(1) %0) {
1717
ret i32 %3
1818
}
1919

20-
; CHECK: define i32 @fn2(i32 addrspace(1)*)
20+
; CHECK: define internal i32 @fn2(i32 addrspace(1)*)
2121
; CHECK-NEXT: %2 = getelementptr i32, i32 addrspace(1)* %0, i32 4
2222
; CHECK-NEXT: %3 = load i32, i32 addrspace(1)* %2, align 4

llvm/test/tools/dxil-dis/opaque-pointers.ll

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ define i64 @test(ptr %p) {
77
ret i64 %v
88
}
99

10-
; CHECK: define i64 @test(i8* %p) {
10+
; CHECK: define internal i64 @test(i8* %p) {
1111
; CHECK-NEXT: %1 = bitcast i8* %p to i32*
1212
; CHECK-NEXT: store i32 0, i32* %1, align 4
1313
; CHECK-NEXT: %2 = bitcast i8* %p to i64*
@@ -19,7 +19,7 @@ define i64 @test2(ptr %p) {
1919
ret i64 %v
2020
}
2121

22-
; CHECK: define i64 @test2(i64* %p) {
22+
; CHECK: define internal i64 @test2(i64* %p) {
2323
; CHECK-NEXT: store i64 0, i64* %p, align 8
2424
; CHECK-NEXT: %v = load i64, i64* %p, align 8
2525

@@ -29,7 +29,7 @@ define i64 @test3(ptr addrspace(1) %p) {
2929
ret i64 %v
3030
}
3131

32-
; CHECK: define i64 @test3(i8 addrspace(1)* %p) {
32+
; CHECK: define internal i64 @test3(i8 addrspace(1)* %p) {
3333
; CHECK-NEXT: %1 = bitcast i8 addrspace(1)* %p to i32 addrspace(1)*
3434
; CHECK-NEXT: store i32 0, i32 addrspace(1)* %1, align 4
3535
; CHECK-NEXT: %2 = bitcast i8 addrspace(1)* %p to i64 addrspace(1)*
@@ -41,7 +41,7 @@ define i64 @test4(ptr addrspace(1) %p) {
4141
ret i64 %v
4242
}
4343

44-
; CHECK: define i64 @test4(i64 addrspace(1)* %p) {
44+
; CHECK: define internal i64 @test4(i64 addrspace(1)* %p) {
4545
; CHECK-NEXT: store i64 0, i64 addrspace(1)* %p, align 8
4646
; CHECK-NEXT: %v = load i64, i64 addrspace(1)* %p, align 8
4747

@@ -53,7 +53,7 @@ define i64 @test5(ptr %p) {
5353
ret i64 %v
5454
}
5555

56-
; CHECK: define i64 @test5(i8* %p) {
56+
; CHECK: define internal i64 @test5(i8* %p) {
5757
; CHECK-NEXT: %casted = addrspacecast i8* %p to i64 addrspace(1)*
5858
; CHECK-NEXT: store i64 0, i64 addrspace(1)* %casted, align 8
5959
; CHECK-NEXT: %v = load i64, i64 addrspace(1)* %casted, align 8

0 commit comments

Comments
 (0)