Skip to content

Commit e95e94a

Browse files
author
Jeff Niu
authored
[mlir][test] Reorganize the test dialect (#89424)
This PR massively reorganizes the Test dialect's source files. It moves manually-written op hooks into `TestOpDefs.cpp`, moves format custom directive parsers and printers into `TestFormatUtils`, adds missing comment blocks, and moves around where generated source files are included for types, attributes, enums, etc. into their own source file. This will hopefully help navigate the test dialect source code, but also speeds up compile time of the test dialect by putting generated source files into separate compilation units. This also sets up the test dialect to shard its op definitions, done in the next PR.
1 parent 5a7c80c commit e95e94a

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+2114
-1354
lines changed

mlir/test/lib/Analysis/DataFlow/TestDenseBackwardDataFlowAnalysis.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
#include "TestDenseDataFlowAnalysis.h"
1414
#include "TestDialect.h"
15+
#include "TestOps.h"
1516
#include "mlir/Analysis/DataFlow/ConstantPropagationAnalysis.h"
1617
#include "mlir/Analysis/DataFlow/DeadCodeAnalysis.h"
1718
#include "mlir/Analysis/DataFlow/DenseAnalysis.h"

mlir/test/lib/Analysis/DataFlow/TestDenseForwardDataFlowAnalysis.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
#include "TestDenseDataFlowAnalysis.h"
1414
#include "TestDialect.h"
15+
#include "TestOps.h"
1516
#include "mlir/Analysis/DataFlow/ConstantPropagationAnalysis.h"
1617
#include "mlir/Analysis/DataFlow/DeadCodeAnalysis.h"
1718
#include "mlir/Analysis/DataFlow/DenseAnalysis.h"

mlir/test/lib/Conversion/FuncToLLVM/TestConvertCallOp.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
//===----------------------------------------------------------------------===//
88

99
#include "TestDialect.h"
10+
#include "TestOps.h"
1011
#include "TestTypes.h"
1112
#include "mlir/Conversion/FuncToLLVM/ConvertFuncToLLVM.h"
1213
#include "mlir/Conversion/LLVMCommon/Pattern.h"

mlir/test/lib/Conversion/OneToNTypeConversion/TestOneToNTypeConversionPass.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
//===----------------------------------------------------------------------===//
88

99
#include "TestDialect.h"
10+
#include "TestOps.h"
1011
#include "mlir/Dialect/Func/Transforms/OneToNFuncConversions.h"
1112
#include "mlir/Dialect/SCF/Transforms/Patterns.h"
1213
#include "mlir/Pass/Pass.h"

mlir/test/lib/Dialect/Affine/TestReifyValueBounds.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
//===----------------------------------------------------------------------===//
88

99
#include "TestDialect.h"
10+
#include "TestOps.h"
1011
#include "mlir/Dialect/Affine/IR/AffineOps.h"
1112
#include "mlir/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.h"
1213
#include "mlir/Dialect/Affine/Transforms/Transforms.h"

mlir/test/lib/Dialect/DLTI/TestDataLayoutQuery.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
#include "TestDialect.h"
9+
#include "TestOps.h"
1010
#include "mlir/Analysis/DataLayoutAnalysis.h"
1111
#include "mlir/Dialect/DLTI/DLTI.h"
1212
#include "mlir/IR/BuiltinAttributes.h"

mlir/test/lib/Dialect/Func/TestDecomposeCallGraphTypes.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
//===----------------------------------------------------------------------===//
88

99
#include "TestDialect.h"
10+
#include "TestOps.h"
1011
#include "mlir/Dialect/Func/IR/FuncOps.h"
1112
#include "mlir/Dialect/Func/Transforms/DecomposeCallGraphTypes.h"
1213
#include "mlir/IR/Builders.h"

mlir/test/lib/Dialect/Test/CMakeLists.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,10 @@ add_public_tablegen_target(MLIRTestOpsSyntaxIncGen)
4747
add_mlir_library(MLIRTestDialect
4848
TestAttributes.cpp
4949
TestDialect.cpp
50+
TestFormatUtils.cpp
5051
TestInterfaces.cpp
52+
TestOpDefs.cpp
53+
TestOps.cpp
5154
TestPatterns.cpp
5255
TestTraits.cpp
5356
TestTypes.cpp

mlir/test/lib/Dialect/Test/TestAttributes.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
#include "mlir/IR/Types.h"
2020
#include "mlir/Support/LogicalResult.h"
2121
#include "llvm/ADT/Hashing.h"
22+
#include "llvm/ADT/StringExtras.h"
2223
#include "llvm/ADT/TypeSwitch.h"
2324
#include "llvm/ADT/bit.h"
2425
#include "llvm/Support/ErrorHandling.h"
@@ -244,7 +245,7 @@ static void printConditionalAlias(AsmPrinter &p, StringAttr value) {
244245
//===----------------------------------------------------------------------===//
245246

246247
#include "TestAttrInterfaces.cpp.inc"
247-
248+
#include "TestOpEnums.cpp.inc"
248249
#define GET_ATTRDEF_CLASSES
249250
#include "TestAttrDefs.cpp.inc"
250251

0 commit comments

Comments
 (0)