Skip to content

Commit e36a393

Browse files
[mlir][SPIRV] Fix build error (#111264)
Fix build error that was introduced by #111250. Also, the deleted function is not needed at all. ``` ../llvm-project/mlir/include/mlir/Conversion/SPIRVToLLVM/SPIRVToLLVM.h: In member function ‘const mlir::LLVMTypeConverter* mlir::SPIRVToLLVMConversion<SPIRVOp>::getTypeConverter() const’: ../llvm-project/mlir/include/mlir/Conversion/SPIRVToLLVM/SPIRVToLLVM.h:35:12: error: invalid ‘static_cast’ from type ‘const mlir::TypeConverter*’ to type ‘const mlir::LLVMTypeConverter*’ 35 | return static_cast<const LLVMTypeConverter *>( | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 36 | ConversionPattern::getTypeConverter()); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../llvm-project/mlir/include/mlir/Conversion/SPIRVToLLVM/SPIRVToLLVM.h:21:7: note: class type ‘const mlir::LLVMTypeConverter’ is incomplete ```
1 parent 206fad0 commit e36a393

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

mlir/include/mlir/Conversion/SPIRVToLLVM/SPIRVToLLVM.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,6 @@ class SPIRVToLLVMConversion : public OpConversionPattern<SPIRVOp> {
2929
const LLVMTypeConverter &typeConverter,
3030
PatternBenefit benefit = 1)
3131
: OpConversionPattern<SPIRVOp>(typeConverter, context, benefit) {}
32-
33-
protected:
34-
const LLVMTypeConverter *getTypeConverter() const {
35-
return static_cast<const LLVMTypeConverter *>(
36-
ConversionPattern::getTypeConverter());
37-
}
3832
};
3933

4034
/// Encodes global variable's descriptor set and binding into its name if they

0 commit comments

Comments
 (0)