Skip to content

Commit c8da53d

Browse files
committed
address comments -- clarify comment
1 parent 980ea86 commit c8da53d

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18765,7 +18765,8 @@ SDValue DAGCombiner::rebuildSetCC(SDValue N) {
1876518765
SetCCVT = getSetCCResultType(SetCCVT);
1876618766
// Replace the uses of XOR with SETCC. Note, avoid this transformation if
1876718767
// it would introduce illegal operations post-legalization as this can
18768-
// result in an infinite loop.
18768+
// result in infinite looping between converting xor->setcc here, and
18769+
// expanding setcc->xor in LegalizeSetCCCondCode if requested.
1876918770
const ISD::CondCode CC = Equal ? ISD::SETEQ : ISD::SETNE;
1877018771
if (!LegalOperations || TLI.isCondCodeLegal(CC, Op0.getSimpleValueType()))
1877118772
return DAG.getSetCC(SDLoc(N), SetCCVT, Op0, Op1, CC);

0 commit comments

Comments
 (0)