[clang][deps] Implement move-conversion for CowCompilerInvocation (#66301)

jansvoboda11 · web-flow · commit c60ee7c7b215 · 2023-09-13T15:51:24.000-07:00
This avoids making copies at the end of
`makeCommonInvocationForModuleBuild()` (in `ModuleDepCollector.cpp`).
diff --git a/clang/include/clang/Frontend/CompilerInvocation.h b/clang/include/clang/Frontend/CompilerInvocation.h
@@ -354,6 +354,9 @@ class CowCompilerInvocation : public CompilerInvocationBase {
     deep_copy_assign(X);
   }
 
+  CowCompilerInvocation(CompilerInvocation &&X)
+      : CompilerInvocationBase(std::move(X)) {}
+
   // Const getters are inherited from the base class.
 
   /// Mutable getters.

Original file line number	Diff line number	Diff line change
`@@ -354,6 +354,9 @@ class CowCompilerInvocation : public CompilerInvocationBase {`
`354`	`354`	`deep_copy_assign(X);`
`355`	`355`	`}`
`356`	`356`
	`357`	`+ CowCompilerInvocation(CompilerInvocation &&X)`
	`358`	`+ : CompilerInvocationBase(std::move(X)) {}`
	`359`	`+`
`357`	`360`	`// Const getters are inherited from the base class.`
`358`	`361`
`359`	`362`	`/// Mutable getters.`